From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2AC35451CA for ; Wed, 11 Jan 2023 11:49:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1039368BC16; Wed, 11 Jan 2023 13:49:05 +0200 (EET) Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E356568BA7C for ; Wed, 11 Jan 2023 13:48:58 +0200 (EET) Received: by mail-ua1-f52.google.com with SMTP id z23so3610006uae.7 for ; Wed, 11 Jan 2023 03:48:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bocu4YS6LlS4vahBF4opaI+o6AA05HNeaUL9JrP1KEs=; b=lDZKYeC1kqO4Cn3ruMdTRZSUF7x8auOM9Dd7IDVoiwD5g5VBEwlP2JIgzPP4uaiLVo oNrLTE+F3SNvfRMzWyqQHlUrTJP+QOhjNbBJDsuAoqapZWeLwXKcKfjb2Os+6R1OXetX FkeXIVVlK3Vqc8ZG/dduC9mzsfcTXV9chM6VEjXTJzRRa7wY4lusxk4eu6xRTVjev5J9 3Q9k4O468o/h9B5NRvpjYfSKA2JMVK+mtyjoXTwg57xISUWyyV4tsApxqTA3n7Dkz99h k1tO+L592vZPODX3HDxDs4Dyufdd7TGYw5sEXW7QzTplaRJfsyLHM7xgDwaVNWoqRvmF Iclw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bocu4YS6LlS4vahBF4opaI+o6AA05HNeaUL9JrP1KEs=; b=iB6Fd3FEoiVGL4JlSWYGO3GdykQNmL6sHbW9zuSOL35Que3vMCSnzEpW6dzQXdT0y7 xV3PSt09vwSD80RT+nuklqXcOmB6e2zVtUqCINJL7EJITZzWMLscr1mdD5NCHNFxigHC Uxc6OamiZq109c9v25NDbd4cSMNyr67fzqI24fHc45X0wrIPwMycjWV5GU7Pex6c8jBl cShS2tcXbi3sbq5qY8YG4POqCMAbh9ghKC75PAfv+9Iqi9e+j+9cT//bvLnZA7Gkt7JD CWh+fUE6Kqp9K/BuZr/bNV4BLqIA5rJNEXvPIASedGJUoAE1W6gvxDa5Ak0sTLbZtpf0 Zv8Q== X-Gm-Message-State: AFqh2kpMEcgEv04w77oU+1zYYQ52332YdQw9KOHSOpj4tHRGF/xR0nuz PXKEJY6lsObWiAxTejLJFiN/riEHcMjkuXEN0PCZdLzj X-Google-Smtp-Source: AMrXdXtVobh66AzEkTeT/TjaiKW8m+sPsJkA0kh6eOlX1QpjxXDsJyqKD2faA6wnqHsSeFES1W5I/iKWT6yCYkovsHQ= X-Received: by 2002:ab0:1d8c:0:b0:447:8177:b614 with SMTP id l12-20020ab01d8c000000b004478177b614mr8340909uak.41.1673437737134; Wed, 11 Jan 2023 03:48:57 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Wed, 11 Jan 2023 03:48:56 -0800 (PST) In-Reply-To: <4a40a9d140aa477fb34cf5704034bd4c@hhi.fraunhofer.de> References: <4a40a9d140aa477fb34cf5704034bd4c@hhi.fraunhofer.de> From: Paul B Mahol Date: Wed, 11 Jan 2023 12:48:56 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Stoffers, Christian" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/11/23, Helmrich, Christian wrote: > Hi, > > >> So its better to use that instead of human written assembly? Does clang >> generate faster code without this asm? > > > I'm not sure I fully understand your questions, but I hope the following > answers it. The reason why we auto-converted our intrinsics code to asm is > not a technical one, we unfortunately just don't have the knowledge or > resources to manually write asm code. If I remember correctly, the SIMD > optimized code runs about twice as fast as the C code, especially on UHD > input. Compare clang compiled ffmpeg without this asm code and with it, and tell if any difference. I'might do it anyway later. > > >> Please remove SLICE_THREADS related flag as there is no call to execute to >> filter in slices. Please remove stdbool.h header and adapt code to compile >> without it. > > > Done, please find attached a second version (v1) of the XPSNR avfilter > patch. > > > Thanks and best, > > > Christian Helmrich > > Fraunhofer HHI, Video Coding and Analytics Department > > > ________________________________ > Von: ffmpeg-devel im Auftrag von Paul B > Mahol > Gesendet: Dienstag, 10. Januar 2023 21:43 > An: FFmpeg development discussions and patches > Cc: Stoffers, Christian > Betreff: Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter > > On 1/10/23, Helmrich, Christian > wrote: >> Hi, >> >> please find attached a patch (relative to FFmpeg master as of early >> January >> 10, 2023) >> adding avfilter support for extended perceptually weighted peak >> signal-to-noise ratio >> (XPSNR) measurements for videos, as described in the related addition to >> filters.texi. >> >> The XPSNR code was originally vectorized using SIMD intrinsics, but we >> concluded that >> FFmpeg code requires asm instead of such intrinsics, so we let gcc >> auto-convert these > > So its better to use that instead of human written assembly? > Does clang generate faster code without this asm? > >> instructions to pure assembly; see the vf_xpsnr.asm file. If the added >> asm >> code is too >> lengthy, intrinsics would be possible, or something else is missing, >> please >> let us know. >> > > Please remove SLICE_THREADS related flag as there is no call to > execute to filter in slices. > Please remove stdbool.h header and adapt code to compile without it. > >> Best, >> >> Christian Helmrich and Christian Stoffers >> Fraunhofer HHI >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".