Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use aligned height when allocating plane buffers
Date: Sun, 20 Nov 2022 18:40:46 +0100
Message-ID: <CAPYw7P6xxirh0RJNfDrDxn+YYbBg0ownMkbxuK+wn9unAogCZQ@mail.gmail.com> (raw)
In-Reply-To: <20221120170625.3578-1-jamrial@gmail.com>

On 11/20/22, James Almer <jamrial@gmail.com> wrote:
> Fixes tickets #10051 and #10052.
>

Not real fix, more like big hack.

> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavfilter/framepool.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c
> index 0404589055..7e830c5a3b 100644
> --- a/libavfilter/framepool.c
> +++ b/libavfilter/framepool.c
> @@ -91,15 +91,13 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef*
> (*alloc)(size_t size),
>          linesizes[i] = pool->linesize[i];
>
>      if (av_image_fill_plane_sizes(sizes, pool->format,
> -                                  pool->height,
> +                                  FFALIGN(pool->height, align),
>                                    linesizes) < 0) {
>          goto fail;
>      }
>
>      for (i = 0; i < 4 && sizes[i]; i++) {
> -        if (sizes[i] > SIZE_MAX - align)
> -            goto fail;
> -        pool->pools[i] = av_buffer_pool_init(sizes[i] + align, alloc);
> +        pool->pools[i] = av_buffer_pool_init(sizes[i], alloc);
>          if (!pool->pools[i])
>              goto fail;
>      }
> --
> 2.38.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-11-20 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-20 17:06 James Almer
2022-11-20 17:40 ` Paul B Mahol [this message]
2022-11-20 17:45   ` James Almer
2022-11-20 19:41 ` StreamNG Harold Camargo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPYw7P6xxirh0RJNfDrDxn+YYbBg0ownMkbxuK+wn9unAogCZQ@mail.gmail.com \
    --to=onemda@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git