From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C02C54335B for ; Sun, 30 Oct 2022 18:20:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A0AB68BD13; Sun, 30 Oct 2022 20:20:21 +0200 (EET) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD6A068B883 for ; Sun, 30 Oct 2022 20:20:14 +0200 (EET) Received: by mail-vk1-f172.google.com with SMTP id m18so4481948vka.10 for ; Sun, 30 Oct 2022 11:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :references:in-reply-to:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bwxQj4vt0FHZIQb7/ZSLuyPOLuZTzqSuvn6KfaMBCf4=; b=H9J4WeRjFF7/+aLrO4CmBWJyNjweHIL4iszZQQm/A+YTQkbIKM3eEPvrknVcckKLQh B+r4Qu6vO788vnQxYVC/2tcz+trYHpTfXE6IaTgVsQX2D2PelpJ8PW6SqGqy7sdAGin/ Oh0Bp2LDipm8aASvivocyNOELL4+ubb+qhhEfBlygTU1uVDyy6XZA0P5Mtac1svn0Z6p +6SdkFzLoYU4p2o1ZyZ2wS8a4uIIlQqt+D1VhHvuIJUcxkkeB7ueRKlKXOlZn9jb/Xbx jHkITwEolLZLCZjsBmD+u3lkzdOI+QdeVrLojoVU6cdG2xjyQTtQs9riJo6Qj5qyGuP5 iWxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :references:in-reply-to:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bwxQj4vt0FHZIQb7/ZSLuyPOLuZTzqSuvn6KfaMBCf4=; b=7giHUyM0ndkBXHW1391/G+Dm3B81XmbyvfHXoEFdqy3uOSXo6hUk6t/uohNIupXtTb n+aiS1JeZJz+GGWFYMNc0dVSeEf96bT//nA/DITq6GL+u3noGvcXZWoK5qPmqZBJGwb1 etmR5NqAR3fkPHPyXnAnH/sTA3PCrdvVTAToN+6OWP8TLRd0c8ztoIzcUYQi90CyVIG1 ehYHfDxNtHeLkBj4qjnHvX4UyIoADeYLOwC2tPpBEOyAKJ8JEXzPOWNaQckwsxiXUKos 9W2B53wnpEBCm+mJCsibUJ9VtcMFEDCEK9gS7bO+qAwyxD7YkUc9hmLkV2LvGzgNvmNo XGDg== X-Gm-Message-State: ACrzQf1gKpRy/qkBnY6IuokeLuLWN5q7yM/zhl+Bxgjxa9rHpkhhvjHU QcKCeNBV2H96aFw/m+YPn6dJD1EjOhw5RUcWDY7NY68J X-Google-Smtp-Source: AMsMyM6hQSI71gJBKOZJWo9h9tvQ3knivuj6OTG3mKq4zH/rwYGNcpnqpsHxPjgkhn3pimpfjXkvEiQBbCy1QKtFWP0= X-Received: by 2002:a1f:2c51:0:b0:3b6:cf06:18cf with SMTP id s78-20020a1f2c51000000b003b6cf0618cfmr3121086vks.17.1667154013102; Sun, 30 Oct 2022 11:20:13 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:612c:612:b0:314:ac6a:1eb7 with HTTP; Sun, 30 Oct 2022 11:20:12 -0700 (PDT) In-Reply-To: <4bf7faf7-7fd8-7b50-8bfc-a6af243bd681@gmail.com> References: <20221030161412.1293-1-jamrial@gmail.com> <4bf7faf7-7fd8-7b50-8bfc-a6af243bd681@gmail.com> From: Paul B Mahol Date: Sun, 30 Oct 2022 19:20:12 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avutil/channel_layout: add a cube channel layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/30/22, James Almer wrote: > > > On 10/30/2022 1:19 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>> doc/APIchanges | 3 +++ >>> doc/utils.texi | 2 ++ >>> libavutil/channel_layout.c | 1 + >>> libavutil/channel_layout.h | 2 ++ >>> tests/ref/fate/channel_layout | 1 + >>> 5 files changed, 9 insertions(+) >>> >>> diff --git a/doc/APIchanges b/doc/APIchanges >>> index 5807bf8069..5aca1d1b5f 100644 >>> --- a/doc/APIchanges >>> +++ b/doc/APIchanges >>> @@ -14,6 +14,9 @@ libavutil: 2021-04-27 >>> >>> API changes, most recent first: >>> >>> +2022-10-xx - xxxxxxxxxx - lavu 57.xx.xxx - channel_layout.h >>> + Add AV_CH_LAYOUT_CUBE and AV_CHANNEL_LAYOUT_CUBE. >>> + >>> 2022-10-11 - xxxxxxxxxx - lavu 57.39.101 - pixfmt.h >>> Add AV_PIX_FMT_RGBF32 and AV_PIX_FMT_RGBAF32. >>> >>> diff --git a/doc/utils.texi b/doc/utils.texi >>> index 627b55d154..907a6b87cb 100644 >>> --- a/doc/utils.texi >>> +++ b/doc/utils.texi >>> @@ -715,6 +715,8 @@ FL+FR+FC+LFE+BL+BR+FLC+FRC >>> FL+FR+FC+LFE+FLC+FRC+SL+SR >>> @item octagonal >>> FL+FR+FC+BL+BR+BC+SL+SR >>> +@item cube >>> +FL+FR+BL+BR+TFL+TFR+TBL+TBR >>> @item hexadecagonal >>> FL+FR+FC+BL+BR+BC+SL+SR+WL+WR+TBL+TBR+TBC+TFC+TFL+TFR >>> @item downmix >>> diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c >>> index 21b70173b7..5af7ea0e01 100644 >>> --- a/libavutil/channel_layout.c >>> +++ b/libavutil/channel_layout.c >>> @@ -197,6 +197,7 @@ static const struct channel_layout_name >>> channel_layout_map[] = { >>> { "7.1(wide)", AV_CHANNEL_LAYOUT_7POINT1_WIDE_BACK }, >>> { "7.1(wide-side)", AV_CHANNEL_LAYOUT_7POINT1_WIDE }, >>> { "octagonal", AV_CHANNEL_LAYOUT_OCTAGONAL }, >>> + { "cube", AV_CHANNEL_LAYOUT_CUBE }, >>> { "hexadecagonal", AV_CHANNEL_LAYOUT_HEXADECAGONAL }, >>> { "downmix", AV_CHANNEL_LAYOUT_STEREO_DOWNMIX, }, >>> { "22.2", AV_CHANNEL_LAYOUT_22POINT2, }, >>> diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h >>> index 059ff70841..3e69163360 100644 >>> --- a/libavutil/channel_layout.h >>> +++ b/libavutil/channel_layout.h >>> @@ -233,6 +233,7 @@ enum AVChannelOrder { >>> #define AV_CH_LAYOUT_7POINT1_WIDE >>> (AV_CH_LAYOUT_5POINT1|AV_CH_FRONT_LEFT_OF_CENTER|AV_CH_FRONT_RIGHT_OF_CENTER) >>> #define AV_CH_LAYOUT_7POINT1_WIDE_BACK >>> (AV_CH_LAYOUT_5POINT1_BACK|AV_CH_FRONT_LEFT_OF_CENTER|AV_CH_FRONT_RIGHT_OF_CENTER) >>> #define AV_CH_LAYOUT_OCTAGONAL >>> (AV_CH_LAYOUT_5POINT0|AV_CH_BACK_LEFT|AV_CH_BACK_CENTER|AV_CH_BACK_RIGHT) >>> +#define AV_CH_LAYOUT_CUBE >>> (AV_CH_LAYOUT_QUAD|AV_CH_TOP_FRONT_LEFT|AV_CH_TOP_FRONT_RIGHT|AV_CH_TOP_BACK_LEFT|AV_CH_TOP_BACK_RIGHT) >>> #define AV_CH_LAYOUT_HEXADECAGONAL >>> (AV_CH_LAYOUT_OCTAGONAL|AV_CH_WIDE_LEFT|AV_CH_WIDE_RIGHT|AV_CH_TOP_BACK_LEFT|AV_CH_TOP_BACK_RIGHT|AV_CH_TOP_BACK_CENTER|AV_CH_TOP_FRONT_CENTER|AV_CH_TOP_FRONT_LEFT|AV_CH_TOP_FRONT_RIGHT) >>> #define AV_CH_LAYOUT_STEREO_DOWNMIX >>> (AV_CH_STEREO_LEFT|AV_CH_STEREO_RIGHT) >>> #define AV_CH_LAYOUT_22POINT2 >>> (AV_CH_LAYOUT_5POINT1_BACK|AV_CH_FRONT_LEFT_OF_CENTER|AV_CH_FRONT_RIGHT_OF_CENTER|AV_CH_BACK_CENTER|AV_CH_LOW_FREQUENCY_2|AV_CH_SIDE_LEFT|AV_CH_SIDE_RIGHT|AV_CH_TOP_FRONT_LEFT|AV_CH_TOP_FRONT_RIGHT|AV_CH_TOP_FRONT_CENTER|AV_CH_TOP_CENTER|AV_CH_TOP_BACK_LEFT|AV_CH_TOP_BACK_RIGHT|AV_CH_TOP_SIDE_LEFT|AV_CH_TOP_SIDE_RIGHT|AV_CH_TOP_BACK_CENTER|AV_CH_BOTTOM_FRONT_CENTER|AV_CH_BOTTOM_FRONT_LEFT|AV_CH_BOTTOM_FRONT_RIGHT) >>> @@ -389,6 +390,7 @@ typedef struct AVChannelLayout { >>> #define AV_CHANNEL_LAYOUT_7POINT1_WIDE AV_CHANNEL_LAYOUT_MASK(8, >>> AV_CH_LAYOUT_7POINT1_WIDE) >>> #define AV_CHANNEL_LAYOUT_7POINT1_WIDE_BACK AV_CHANNEL_LAYOUT_MASK(8, >>> AV_CH_LAYOUT_7POINT1_WIDE_BACK) >>> #define AV_CHANNEL_LAYOUT_OCTAGONAL AV_CHANNEL_LAYOUT_MASK(8, >>> AV_CH_LAYOUT_OCTAGONAL) >>> +#define AV_CHANNEL_LAYOUT_CUBE AV_CHANNEL_LAYOUT_MASK(8, >>> AV_CH_LAYOUT_CUBE) >>> #define AV_CHANNEL_LAYOUT_HEXADECAGONAL AV_CHANNEL_LAYOUT_MASK(16, >>> AV_CH_LAYOUT_HEXADECAGONAL) >>> #define AV_CHANNEL_LAYOUT_STEREO_DOWNMIX AV_CHANNEL_LAYOUT_MASK(2, >>> AV_CH_LAYOUT_STEREO_DOWNMIX) >>> #define AV_CHANNEL_LAYOUT_22POINT2 AV_CHANNEL_LAYOUT_MASK(24, >>> AV_CH_LAYOUT_22POINT2) >>> diff --git a/tests/ref/fate/channel_layout >>> b/tests/ref/fate/channel_layout >>> index 19bcbce7d8..02eaad0929 100644 >>> --- a/tests/ref/fate/channel_layout >>> +++ b/tests/ref/fate/channel_layout >>> @@ -25,6 +25,7 @@ hexagonal FL+FR+FC+BL+BR+BC >>> 7.1(wide) FL+FR+FC+LFE+BL+BR+FLC+FRC >>> 7.1(wide-side) FL+FR+FC+LFE+FLC+FRC+SL+SR >>> octagonal FL+FR+FC+BL+BR+BC+SL+SR >>> +cube FL+FR+BL+BR+TFL+TFR+TBL+TBR >>> hexadecagonal FL+FR+FC+BL+BR+BC+SL+SR+TFL+TFC+TFR+TBL+TBC+TBR+WL+WR >>> downmix DL+DR >>> 22.2 >>> FL+FR+FC+LFE+BL+BR+FLC+FRC+BC+SL+SR+TC+TFL+TFC+TFR+TBL+TBC+TBR+LFE2+TSL+TSR+BFC+BFL+BFR >> >> Is this a common name or is this something you made up? > > It's the same as kAudioChannelLayoutTag_Cube from AudioChannelLayoutTag > as defined by Apple and used in mov (see MOV_CH_LAYOUT_CUBE in lavf > mov_chan.c). Yes, but that is not same as CUBE as used in ambisonics iiuc. > >> >> - Andreas >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".