Re: [FFmpeg-devel] [PATCH] avfilter/framepool: fix alignment requirements for audio and video filters

From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: fix alignment requirements for audio and video filters
Date: Mon, 21 Feb 2022 12:34:50 +0100
Message-ID: <CAPYw7P6ryQGYjfJ-OjL6SdsvEP29h2U68hxCBE+bCgp2CmJ5_w@mail.gmail.com> (raw)
In-Reply-To: <164544167241.19727.2074552888266890134@lain.red.khirnov.net>

On Mon, Feb 21, 2022 at 12:08 PM Anton Khirnov <anton@khirnov.net> wrote:

> Quoting Paul B Mahol (2022-02-20 19:07:47)
> > diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c
> > index aab408d355..aaf1642b4f 100644
> > --- a/libavfilter/framepool.c
> > +++ b/libavfilter/framepool.c
> > @@ -76,15 +76,13 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef*
> (*alloc)(size_t size),
> >      }
> >
> >      if (!pool->linesize[0]) {
> > -        for(i = 1; i <= align; i += i) {
> > -            ret = av_image_fill_linesizes(pool->linesize, pool->format,
> > -                                          FFALIGN(pool->width, i));
> > -            if (ret < 0) {
> > -                goto fail;
> > -            }
> > -            if (!(pool->linesize[0] & (pool->align - 1)))
> > -                break;
> > +        ret = av_image_fill_linesizes(pool->linesize, pool->format,
> > +                                      FFALIGN(pool->width, align));
> > +        if (ret < 0) {
> > +            goto fail;
> >          }
> > +        if ((pool->linesize[0] & (pool->align - 1)))
>
> Check all of them, not just the first one.
>

Will do, it could overflow (among other things) in theory and result than
would not be wanted one.

>
> Otherwise looks good.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".