From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3D3F642CDC for ; Tue, 3 May 2022 16:17:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3F0B368B3C8; Tue, 3 May 2022 19:17:42 +0300 (EEST) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B5B5268A848 for ; Tue, 3 May 2022 19:17:34 +0300 (EEST) Received: by mail-yb1-f178.google.com with SMTP id v59so31878776ybi.12 for ; Tue, 03 May 2022 09:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WNNIQDQDGJR7sX+xVfPZ4QDRLe7OA0nqbIc1k4EomgI=; b=bnmFKKgvTfP/Z4GBkrCpzhn5Hx3ZhMJ7v2ogBgII/mpbLA5qKqrw5maQ1hbgSmFSpp eRWQDJrBW4QwfyEdxM9eMbcjx/4ip3dbKqS+O4rjFyCq3M7K7VTxdxOtxX9+ARYWY2G9 NRQ4vEnvzDJTlYEtYF4WlQlOT2wAvCGSMWuxY7G+yOeEzMrgCRgriitCVJuVf/bfSyDD I253BWD1AH6uicgHAa7aInVVPn50BfT0l3ubjurPyixT6kAP31i7m2L+rLoEv5RaNf1F foh5cfRTK2MXQl2pQlEj+rIOr8Ye+9yIOGOnYzcRSTjGQT4Dr+0SUcHmPPQfdWOKSfuh +vjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WNNIQDQDGJR7sX+xVfPZ4QDRLe7OA0nqbIc1k4EomgI=; b=KtQu1SCMt057AIekxglgC19ebKKeAUALtfsm/nUiCeD/SVScrJwdl6c16eLAbTVPuo 3zs8TDUVLsCmWuMK4wKief2Y9BqGf/RRWre8EV2DV0FwBZtTTKGp5C0/zfYxKcWEUfmH RN9TnhnYi72HgdIcTXcyCdRQ7eA1QQO1dpN+JXzEztwuBnFOZsrxLQCnrdhqJ4A8YuzF Sh7N4cwIuMWeu80lrQ/AG/fy4TjRZbKs6H45Fgx/Z0GOIQoYgWLqI43SBvpubLM5TAMK BKwFTE2LzB+XAkRIL3h4unY1PofEOb9JH01j9A6WVtQwXzA5VZHsV+pic53XtKrP9d1o coEw== X-Gm-Message-State: AOAM532gQvyJy0SE165w+md9VQzlYVbUuMWjt5Wi3MJNnDz6BgLf9A45 HCCSwYfZNWdubOf2sHkzk/L3kXS2f7+cgPqPEItG54WZ X-Google-Smtp-Source: ABdhPJy++4c+umsvpLL3CC2kwbrtN1B7g11MqoS+q6H3vPwxsLLDO2as9Q0/AqFL0yZXv92w/laOgxnLAJ6Lhk7/mC8= X-Received: by 2002:a25:4483:0:b0:645:340c:29af with SMTP id r125-20020a254483000000b00645340c29afmr14535357yba.586.1651594653290; Tue, 03 May 2022 09:17:33 -0700 (PDT) MIME-Version: 1.0 References: <20220503161328.842587-1-traian.coza@gmail.com> In-Reply-To: <20220503161328.842587-1-traian.coza@gmail.com> From: Paul B Mahol Date: Tue, 3 May 2022 18:20:01 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality! X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Traian Coza Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, May 3, 2022 at 6:13 PM Traian Coza wrote: > I added the possibility of converting text-based subtitle tracks (such as > subrip or ass) to bitmap-based subtitle tracks (such as dvd_subtitle). > > I accomplished this by using libass, and basically using the code from > vf_subtitles.c to render text subtitles and store the images in the > AVSubtitle structure. > > Of course, this functionality will only work when ffmpeg is configured > with --enable-libass. > > Sorry but i think this needs to be in libavfilter instead of libavcodec. And for libavfilter one needs to add proper, not hacky, subtitle support to library. > Traian Coza (12): > Implemented text to bitmap subtitles! > Render only when necessary > Retreive width and height from video stream! > Initialize ass library only once! > Cleaned up > Wrote proper headers > Close libass after using > Added standard headers > Rearranged files, all tests are passing! > Rearranged files, all tests are passing! > Added logging > Added more logging > > fftools/Makefile | 2 + > fftools/ffmpeg.c | 35 ++++- > fftools/text_to_bitmap.c | 300 +++++++++++++++++++++++++++++++++++++++ > fftools/text_to_bitmap.h | 37 +++++ > libavcodec/avcodec.h | 9 ++ > 5 files changed, 382 insertions(+), 1 deletion(-) > create mode 100644 fftools/text_to_bitmap.c > create mode 100644 fftools/text_to_bitmap.h > > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".