From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9319942397 for ; Tue, 15 Mar 2022 08:51:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1E3D768A115; Tue, 15 Mar 2022 10:51:56 +0200 (EET) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 007D368A115 for ; Tue, 15 Mar 2022 10:51:49 +0200 (EET) Received: by mail-yb1-f177.google.com with SMTP id e186so35888594ybc.7 for ; Tue, 15 Mar 2022 01:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=l+SLdsKVKckuau7OCFIIvtEobsXWhQfmP7goDAv0m20=; b=dBjPzdEBikXTNGLHC4260foLrcf0KNNmxNZfdM/LEHloPzsSs9rF53E0cfKYpN6UU7 Y3E5JPnjk8YXFayI71COnMFTb/t+pXDWFTkUBpWVWVJcXv0PJ2ukCzrbqyf9SjOHop4b VplP6nUO5RojVWDYkWIaeh273PsanO0UMl7jWsTtMQpuWv0ORBORrSLbi5HU8aBVIbCo 4k9mu7V+G8iEbYM49ai2uyHrVmrD6dupJXueX3FvWwl3s5u5opNB7YWuXK9BESAkp59s GN5QKmLPeoNXmBJYMzQpsH4XvyYC+TGpzkKKSAiw0BlkZmMF4xkwASf0ThxvFjubbwdp 3l2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=l+SLdsKVKckuau7OCFIIvtEobsXWhQfmP7goDAv0m20=; b=LSe4PzjYq0/elx+JRqMaOxcojnxX8y3iuW1QKYcus3Wln4DgZc5wgCPHsPZ4uyYKHX mAPCdlfJNn78fJXrgmCjMAhdJu4ROOKDSu7nzLfEuZbt9YBCBAsQBchyARRnMLbnucL4 vTbEIHTlcd87bfbPBT0xAvYGx9WnQgb14a0wBXfQ+b/6+Ms0rCzoY3sPBGJJAxB8XNXd 681vL3XuwJ3up4tZwBE+jnoYm1gqzxKFhRnSGlb36Pfz7Ak4MV1Koz7cQhviS3y5xJye KCF4lTmCYdoCE8eijAGCw/a7ijvd97cQug67GAguirxo62jJJnFEHutc8Rhc7hzHa61Y UTMQ== X-Gm-Message-State: AOAM531dRsYllK1CtLyznhL74l4qUpDIQMCACfx7JgT9UxD4C4pGYrWK FtNtWMgIrdNPIaZZVehWiseYfN1/KMvIe1eAzpkouyvi X-Google-Smtp-Source: ABdhPJz2wkWQ16we4TsnEYXKi/jg3rkQ+WsVxhZe+ME+Wo3Whsz7xwhoXhjnRBn+U0Ubc6S4WSQAr+wwkVgVCz3SPn8= X-Received: by 2002:a25:cbd7:0:b0:633:653b:70bc with SMTP id b206-20020a25cbd7000000b00633653b70bcmr4945313ybg.49.1647334308432; Tue, 15 Mar 2022 01:51:48 -0700 (PDT) MIME-Version: 1.0 References: <20220314115602.263642-1-onemda@gmail.com> <164733404216.19727.13997273471475705829@lain.red.khirnov.net> In-Reply-To: <164733404216.19727.13997273471475705829@lain.red.khirnov.net> From: Paul B Mahol Date: Tue, 15 Mar 2022 09:53:39 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add null encoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Mar 15, 2022 at 9:47 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2022-03-14 12:56:01) > > +static int null_encoder(AVCodecContext *avctx, AVPacket *pkt, > > + const AVFrame *frame, int *got_packet) > > +{ > > + int ret; > > + > > + pkt->pts = frame->pts; > > + if (avctx->codec_type == AVMEDIA_TYPE_AUDIO) > > + pkt->duration = ff_samples_to_time_base(avctx, > frame->nb_samples); > > + pkt->flags |= AV_PKT_FLAG_KEY; > > + if ((ret = ff_alloc_packet(avctx, pkt, 1)) < 0) > > + return ret; > > + *got_packet = 1; > > Why return packets at all? Wouldn't it be simpler to just never return > any data? > But than there is no progress report at all. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".