From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 134C24127B for ; Thu, 10 Nov 2022 12:53:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9AF4168BBC6; Thu, 10 Nov 2022 14:53:01 +0200 (EET) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B3CCF68B455 for ; Thu, 10 Nov 2022 14:52:55 +0200 (EET) Received: by mail-vs1-f48.google.com with SMTP id 3so1911927vsh.5 for ; Thu, 10 Nov 2022 04:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=HbCpP8MuO+xB/0LsOdnTY0JSLDtW/HJac+CpLKo530U=; b=PBAvem4fE5Ny44NAarV3vpyTgclKKFGOW7Lb9kOWWs+2q3eo6bbFX9Y5U1c2Ohsba7 L8GTH9P3gmuGV35TvSsfZ9eV93ZIKAHB6PxcWBxJ5RuFeVP51gO5TUkvr0AvZMaY2OyY 6WTiF+46CXeVNNXlVQcox4dwgoFaoIIqcH4Ok/AK4oWG1XWmzHjxGqtNP657XkAO+IIe Jvg+rV3hz/1AGlctcJFq9DUzvP3A4HHaRo9zsj+4yBBJ2Zoi+u/G8hdf45yRC3Hw13rI 9kkuCTojyBnrYqjmfrWe4HVKTQmwW64ebrcsthGzYn4xRC0vjGNQh3vEDMoxq0AfiWn7 P5Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HbCpP8MuO+xB/0LsOdnTY0JSLDtW/HJac+CpLKo530U=; b=DZhi8dqdw/PP7jvsbJPn7SJB8aEp1zn3UVXNjr3YDjnR3Upleooqi+sYIyklZCMkQD UlJpft0It67hvTk4K92QNvAbanN8QyoXbXKR9XojIyzZevogH5qXYKzZVAwZMtr6HlaO CF76pCUerFtTLZsWtDInLdB8BK1muOVCOAf16JagFRgQpO7OThigagDCUSbZEDjc6wQ6 LfFmIpLKZb6mSYw1oJ0Wr3ydEECmsusTY2jVxR2JGvl0jU5fH1qwS9bpWxx4uQuyTNuz HqsRLywzETMcHyxAIjn012B4Fg5A/bCXRie9EeLJKL5vZzRI+rYb2wUziFhYZooJQ6wO gGfQ== X-Gm-Message-State: ACrzQf2k3DLA3NLdbdK9oUuD49ScZOQYn0p8kDcvA9BkacunuWiKCVmn CuR1DqiRXES4u/ULEaSNIfH8Pq5LKizv6wPjddUwF7jr X-Google-Smtp-Source: AMsMyM6Ca9SwqLdW17B01A8EgbFaNgIJWu7i0tEH/H4+tPuj5+fj8la9jMGNgNRM+cu+HjzR5IUd+nC4fph7WUs6hwM= X-Received: by 2002:a67:ad06:0:b0:3a7:d7bc:c2e9 with SMTP id t6-20020a67ad06000000b003a7d7bcc2e9mr2762686vsl.61.1668084773536; Thu, 10 Nov 2022 04:52:53 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Thu, 10 Nov 2022 04:52:52 -0800 (PST) In-Reply-To: <166808350478.1198.18430086573897178566@lain.khirnov.net> References: <20221108112550.8375-1-anton@khirnov.net> <20221108112550.8375-2-anton@khirnov.net> <20221110122827.GZ1814017@pb2> <166808350478.1198.18430086573897178566@lain.khirnov.net> From: Paul B Mahol Date: Thu, 10 Nov 2022 13:52:52 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/5] lavf/demux: treat EAGAIN as REDO unless AVFMT_FLAG_NONBLOCK is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/10/22, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-11-10 13:28:27) >> On Tue, Nov 08, 2022 at 12:25:47PM +0100, Anton Khirnov wrote: >> > Lavf only supports a very limited approximation of non-blocking >> > behavior, so we should not return random EAGAINs to callers unless they >> > specifically requested it. >> > --- >> > libavformat/demux.c | 8 ++++++-- >> > 1 file changed, 6 insertions(+), 2 deletions(-) >> >> this changes seeking behavior of for example: >> libavformat/tests/seek fate-suite/dss/sp.dss >> >> (this seemed to return EAGAIN before sometimes) > > Are you saying that is wrong? I don't see why seeks should return EAGAIN > either. > It returns internally when passing seeking to generic seeking. Please do not break seeking in demuxers. > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".