From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BD86E40196 for ; Sun, 5 Mar 2023 16:37:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 45AB5680A4D; Sun, 5 Mar 2023 18:37:18 +0200 (EET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7EA8A680A4D for ; Sun, 5 Mar 2023 18:37:12 +0200 (EET) Received: by mail-vs1-f47.google.com with SMTP id f23so6949028vsa.13 for ; Sun, 05 Mar 2023 08:37:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678034231; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ziXH1eX86MFBVTNJwdpgrmgQkTfCVTWggFGC54ebcVc=; b=q037373oK5aAciJwrXgaba2JYDqsmvUxbMbnV+c8Fe0FgiYqJBuOJ4nhcTSBF8U15s njUWD1iqeWNKW1MwBUERO/Bv3PcJG3N+5JDrykYwvcLYlEdHF4ycyKoMCC+vsWbxOgX3 qr31Pjb1BZk9UmivmJ4pCizUfPVbAMjsgYOQf67AFI1R4EWLxazdI28xAvB6AXMy83f9 apdmII8JGBineO4gIZIo0c5R2DVwjOkPEsAqGLfdftQ9I7CvR8cL0C1jxcb0yz7Uiklk d7ZZk73hQdKEGMr1uC8vnp61C9IoOTlBZArrigLZQK4XsU3IfscU37LVMeIbEwzcOJd4 97iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678034231; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ziXH1eX86MFBVTNJwdpgrmgQkTfCVTWggFGC54ebcVc=; b=Oypa+oIslDzh10d0WJMSM00ZEjdx2KBeQObdQiPRPVtXeqLyGwpk0ZWF52FIow7bvV gJFWURpJeoeCbXgvZ5KOgbWk4hZszkli4bifTivD0LbBTuEyNhQv/ClyAHEfI09cH+BE nlfT1a2HyViS3pImGpNCv/YTSoOK5qkVt7iyWHoY4+7UYVijJ/KNKVwkGAE/yjbZUScI ZdeNf+ujbUcFHMeO4739OK6SYyk4asLxmu8rer+/KWUmvuWEtfSiwZMvngF141Isaiwp h54Y0qa8OSPQXsWeF1IN1p0A1/9SJez2D4zJMVoQjUccxIi9ezmSQ/qWxq5iiB+c6ZEk ViQA== X-Gm-Message-State: AO0yUKWrXRL+xcxItEjYyBT/ISrqgWixx4x9xXE3zL4hbTZcI3BSulr1 eWW+sYFXdK/fyQDiViEs1YwxnhiLDLs6He1XDjoocTqO X-Google-Smtp-Source: AK7set9N0hc5jPlGlp0L+uPEfFLK7JNpYo7xc7/CpL5QQcEiq7OXAIsJybaJZKTW2wMq3esjuyN6YUJecI6HIeaYFwQ= X-Received: by 2002:a67:d48c:0:b0:402:999f:44d2 with SMTP id g12-20020a67d48c000000b00402999f44d2mr5687500vsj.0.1678034230912; Sun, 05 Mar 2023 08:37:10 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a59:ce4c:0:b0:3ae:9a20:c57e with HTTP; Sun, 5 Mar 2023 08:37:09 -0800 (PST) In-Reply-To: <20230305114346.19875-1-michael@niedermayer.cc> References: <20230305114346.19875-1-michael@niedermayer.cc> From: Paul B Mahol Date: Sun, 5 Mar 2023 17:37:09 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/5/23, Michael Niedermayer wrote: > Fixes: left shift of 538976288 by 13 places cannot be represented in type > 'int' > Fixes: > 56148/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-6257370708967424 > Please make sure that this does not break decoding. > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/rka.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/rka.c b/libavcodec/rka.c > index 2212e3f930..1e6a48568d 100644 > --- a/libavcodec/rka.c > +++ b/libavcodec/rka.c > @@ -207,7 +207,7 @@ static int chctx_init(RKAContext *s, ChContext *c, > c->bprob[0] = s->bprob[0]; > c->bprob[1] = s->bprob[1]; > > - c->srate_pad = (sample_rate << 13) / 44100 & 0xFFFFFFFCU; > + c->srate_pad = ((int64_t)sample_rate << 13) / 44100 & 0xFFFFFFFCU; > c->pos_idx = 1; > > for (int i = 0; i < FF_ARRAY_ELEMS(s->bprob[0]); i++) > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".