From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4854744468 for ; Sat, 10 Sep 2022 19:46:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 709EC68BB22; Sat, 10 Sep 2022 22:46:32 +0300 (EEST) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 40E2668B940 for ; Sat, 10 Sep 2022 22:46:26 +0300 (EEST) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-324ec5a9e97so55959677b3.7 for ; Sat, 10 Sep 2022 12:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date; bh=KIYbAujpWTDy1Z8k0mE6PF4b3EOfk3p0Ce8DM3TRGvU=; b=L7a+FScygPh+B2UYZwMMJsB+uTprzsWq2i3OmUiw/LyfHtP8rDLAl1pu+c65GgAHzM QO3zLxnR2yOiyd9qUKXpJHM3G9z55s8+Tvzvs3nYAG1fURfejuYTQ0sopArGvPmpgm02 SEfZJKYmM9snF02TCXCn/x8cuXyTI5aCjretzRjyebO+Ps3gFMIAcaceetGuTYUqFDnA ZbUaSz4TaN627cf50VEPZd79/4w9nEnNIQpkaWFrzHjXZSbbzfsAuoD13fU+vMcK+gn3 l1vWJHOw32Uvd/rLiNFRM01EIHSOYRIzWb43J0he6R9QzPcepj/+QBxDuL673iI/aQ+1 dTTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=KIYbAujpWTDy1Z8k0mE6PF4b3EOfk3p0Ce8DM3TRGvU=; b=wHvfWzTkS/yymeU6lvuGCWNNNtuYoLPUmShXBt7K41JYKQNLRgHTAOZ7Ril3YhtBbZ A0/tGJ87ByWw3s1p/0ikSuB/SXAO0SXrFdR97JO4YzenGnNyeMjZQ4+07GDEPWz8cTC+ DpQyobU87RN1yIGzPHLpq7+o4xrX6SVXcmM5bR7Lzs0Eil/hynNjzqONyiNYzUS5DglN aWY5mhSwnTGVS4E32/iro8f0E1lD3YOGXxOVtpnbn4TR7iZI19E2uARwL0/2P5j466uS I0hL3Yt1jb6hphj0snHbobJVoX7Mx+b6ABgDlTAQIu86Iqajkoh9vcDrIgRXLtyFSPME xnEA== X-Gm-Message-State: ACgBeo2LFh50VLpEcl5ciw593DH/0eYWslc7WTdRi8tJp4cfCsU7I++/ XmUEdw1KmZ8Z1WvsvkcMXltVwrQIhqwOJLVZnue9/Y3K X-Google-Smtp-Source: AA6agR5Pranxwd4tHW3PRMG/knxu1uDzajyxfJx2N5yR3iPaKY/cFrfa8Gnh4EgOAd5pdOUEKgOh2EGzUekzCGd/EU4= X-Received: by 2002:a81:6bc2:0:b0:348:c484:c365 with SMTP id g185-20020a816bc2000000b00348c484c365mr7632453ywc.516.1662839185046; Sat, 10 Sep 2022 12:46:25 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:7402:0:0:0:0:0 with HTTP; Sat, 10 Sep 2022 12:46:24 -0700 (PDT) In-Reply-To: References: <75911db2-2335-ec54-02c7-7ef77f7b5649@gmail.com> <3404efdf-af40-201a-ad29-3e5c0e2028ee@gmail.com> From: Paul B Mahol Date: Sat, 10 Sep 2022 21:46:24 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec: Micronas SC-4 decoder and parser X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/10/22, Paul B Mahol wrote: > On 9/10/22, James Almer wrote: >> On 9/10/2022 4:11 PM, Paul B Mahol wrote: >>> On 9/10/22, James Almer wrote: >>>> On 9/10/2022 3:27 PM, Paul B Mahol wrote: >>>>> Patches attached. >>>> >>>> This looks like it would fit in adpcm.c as an ADPCM codec. >>> >>> Nope >> >> nibble, step, prediction. All terminology taken straight out of adpcm, >> down to the decoding process. >> The entire decoder can surely be implemented in adpcm.c and named >> adpcm_msc4, and unless you have a good reason not to I'd really like you >> doing so, because once the AVCodecID is added renaming it becomes a PITA. > > It have parser, and if you look actually carefully different > layout in packets, not sharing anything with adpcm.c code. > > So please refrain from non-constructive comments. Also it is not really ADPCM codec as it have dynamics weights and use dot product too. So next time look at code more carefully. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".