Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

[Paul B Mahol <onemda@gmail.com>]

On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> The discrepancy between the definition and the declaration
> in allfilters.c is actually UB.
>

I get no such message with ubsan.


>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavfilter/vf_ccrepack.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_ccrepack.c b/libavfilter/vf_ccrepack.c
> index 61eb2128ae..950bb7b528 100644
> --- a/libavfilter/vf_ccrepack.c
> +++ b/libavfilter/vf_ccrepack.c
> @@ -92,7 +92,7 @@ static const AVFilterPad avfilter_vf_ccrepack_outputs[]
> = {
>      },
>  };
>
> -AVFilter ff_vf_ccrepack = {
> +const AVFilter ff_vf_ccrepack = {
>      .name        = "ccrepack",
>      .description = NULL_IF_CONFIG_SMALL("Repack CEA-708 closed caption
> metadata"),
>      .uninit      = uninit,
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".