Re: [FFmpeg-devel] [PATCH] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

[Paul B Mahol <onemda@gmail.com>]

On Wed, Jun 14, 2023 at 10:01 PM Roy Funderburk <royffmpeg@funderburk.us>
wrote:

> Hi,
>
> I updated the libavcodec patch per Paul Mahol's reviews:
>
> dtsuhd_common.c:496 get_bits_long instead of get_bits used for reading 36
> bits
>
> dtsuhd_common.c:224 get_bits_var changed to accept arrays in VarBits
> structure, allowing arrays with all values less than 256 to use uint8_t
> arrays.
>
> Also removed bitfields from structures.
>


get_vlc2 can be made for get_bits_var(), first table bits (that are still
int and not uint8_t), the code that picks table index from which to take
bits.

It is also possible to make it take both first index and rest of it and
build bigger tables but that is very very advanced step for new
contributors.

Use INIT_VLC_SPARSE_STATIC, there are myriad examples in libavcodec, one of
them being imm4 decoder.


>
> Regards,
> -Roy
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".