From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5C0264124F for ; Wed, 16 Feb 2022 08:07:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 678A568B28F; Wed, 16 Feb 2022 10:07:34 +0200 (EET) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC9C068AF73 for ; Wed, 16 Feb 2022 10:07:27 +0200 (EET) Received: by mail-yb1-f173.google.com with SMTP id 124so3586032ybn.11 for ; Wed, 16 Feb 2022 00:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=00tBl4uiKhpKkTulaAkL+YabHZtUJlkEKx5AfL3KokA=; b=QHu8PfwUxuE6LCx20Wi44M3+r/jEzlykcZiist1UgSJcqhLmoBlxaRuo3rPmUcbaqW SFIZovk4qqM/j9fV/B2YkhLSrolsObII1lhBzF/EOFj9Z8YKp4uOdU5BjzTUAiiOi0ru 5EKF74y0I7OB82BBisYQ6g2KE44e95PLNNQyr4pDadoL0qYsjSWrB39cNOOQVMUilDAC l44p0hxqLCJRrohhFhxxScxZuXH+unAeq+QzgaZ8THWyRyY/kJQboDDhdq0fHHtGvlxD ayj5eWlm6KrpokOe7t3EpKP+N/UaD//2Y36yOGN1pagt+R9CtDOQ8bEYANrZwflh2czN o73w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=00tBl4uiKhpKkTulaAkL+YabHZtUJlkEKx5AfL3KokA=; b=KLuMia3/leUwYI6N4n2EgNRmZbMmJmKsvIud74hR+waXAPnK3giBLShtH7Rndxg5xZ 38MvOPYpVE+pdzaOjquyZj5jyLEEeA3JGfDHsCI+rut744HCqpWKawDJt1YY+5ojIJFT dde1LI3SkF83zw3XtVyU/9dYNH2g9GlHpCbDSC5hGukcs6zK16gomOthPJd+pMh3pwOJ wz/g39rUCggIJtZYkeROqNXnSW94t89OdTNyIj1Y/hxqef9u5wFONEZApQJAQ0Jp6znm 2JKhGtQpjMz6eizHPYShwNWO73nosa41SlB62WHcrL3SHLkIrFGfj7ILCsQyLmKDESTo l50w== X-Gm-Message-State: AOAM533csdwYX8dp2i7+dRZ4bSpWRw3tn1mhYIIAO5t+XDHCyOKXWQYG iQoYkc+fYbfryaqI0oq0jo4tpeTCSuKCGFHa5Gae1docGrY= X-Google-Smtp-Source: ABdhPJxOHbxhxpA/6b8HLETuqCWCEI5alOlAhd0us+H6pXZGKZGLEJcGfJ7WKHp99SbgeDlyCPLWSicyz/oeoxOO9ws= X-Received: by 2002:a05:6902:4e2:b0:611:19fc:a30 with SMTP id w2-20020a05690204e200b0061119fc0a30mr1097722ybs.431.1644998845857; Wed, 16 Feb 2022 00:07:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul B Mahol Date: Wed, 16 Feb 2022 09:08:53 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove unused buffer frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Feb 16, 2022 at 7:02 AM Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Forgotten in 03c8fe49ea3f2a2444607e541dff15a1ccd7f0c2. > > Signed-off-by: Andreas Rheinhardt > --- > What is actually the use-case of these filters? The documentation states > that they are auto-inserted, yet this is no longer true any more since > 4ca1fb9d2a91757c8c4c34dd456abf340e3f765f. > Now avfilter buffers internally if needed, so filters are no longer useful. Also they seems to call malloc for every input frame. > > libavfilter/fifo.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/libavfilter/fifo.c b/libavfilter/fifo.c > index 1c7be88ae1..8b34055fde 100644 > --- a/libavfilter/fifo.c > +++ b/libavfilter/fifo.c > @@ -38,13 +38,6 @@ typedef struct Buf { > typedef struct FifoContext { > Buf root; > Buf *last; ///< last buffered frame > - > - /** > - * When a specific number of output samples is requested, the partial > - * buffer is stored here > - */ > - AVFrame *out; > - int allocated_samples; ///< number of samples out was allocated > for > } FifoContext; > > static av_cold int init(AVFilterContext *ctx) > @@ -65,8 +58,6 @@ static av_cold void uninit(AVFilterContext *ctx) > av_frame_free(&buf->frame); > av_free(buf); > } > - > - av_frame_free(&s->out); > } > > static int add_to_queue(AVFilterLink *inlink, AVFrame *frame) > -- > 2.32.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".