From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8E56A451D6 for ; Wed, 11 Jan 2023 11:53:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F54868BC16; Wed, 11 Jan 2023 13:53:33 +0200 (EET) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7228D68B914 for ; Wed, 11 Jan 2023 13:53:27 +0200 (EET) Received: by mail-vs1-f51.google.com with SMTP id o63so15399643vsc.10 for ; Wed, 11 Jan 2023 03:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aO3dhvYA4DYPEa7s7osfiCR7bHCrEvotcNjx12RRx9k=; b=ClW70k2bFqA2AMd4mj3K7glbbrpdAHJ2b2obdFPsJJ1DwJFBTQyCGwydXfHp5LpegO Q6O6MTFz8hxnufHjp2XdPlg6j16iMLFvev8rn1nn2J87GOVSVi/Ar/LutW54Z6r4u/HE srZpSF42uSWtzGCd3ztasREYMBAn5QKjpDXUjXgo60DeZJ0r5o45AlmG03K1sz4secmK i6SKaicbQbDDgiM7dUl/sOQbvCZZd8gTrfe6qJxMgnKftmvbyLSjOz9SRrqRMBu04YlT PIwsecLjMVO2ogo5CNegYaNDpLcdamEMZO+nNPpEqOrcy9AVpxMfh+KicVkOFgPnV0yn fvXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aO3dhvYA4DYPEa7s7osfiCR7bHCrEvotcNjx12RRx9k=; b=siHI8Gja9z1ZJxeNEaef2SXsOAcc5r6HxgihDcgyRnPMPtl7sfPrLcXFm3GB3YHDXY dgeQYiJNyjjLfl8gIoK9r0OqS1Rd9ahjFnklsMVU08SD+9zPGjI8WfI+N0++DyAsBzdY Wak85HKrnxzSyJhtWRORXs6DQe6glFgDASkuM2MiYBi8LRhzwkhJJnSoQMxxNeMmrlaU M1YjHE7wdby/IjJWC5KySUhhBlYJecUBraXSWWk+3Gc//HMD98pjZnuvx+acSueDprvG f/V1pFmzsXmKKRWR3VQu/ofHylnmhnrZ/qTDoitOQmSGGDQ99LnTDDmr2nUqycXa6Vqi VV8A== X-Gm-Message-State: AFqh2kpUfb0igJ5LM+bqg8Oda9kGrTjd+klkUP6iI3kQPyUuAQLdOfVV lH4hKRWaEa+uFcGQx6l6RsXLbR2tEuoKAuRUudGwdGEz X-Google-Smtp-Source: AMrXdXv1v97p/igeZw56f0ksFhkRrbmmPtmRtPOp0s4PK3lpfCLWOK2/nPBrWq86eoFmHfPZbPjARsYB6pGdzco4A44= X-Received: by 2002:a05:6102:14a9:b0:3cb:b9c:4a24 with SMTP id d41-20020a05610214a900b003cb0b9c4a24mr6278991vsv.57.1673438005823; Wed, 11 Jan 2023 03:53:25 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Wed, 11 Jan 2023 03:53:24 -0800 (PST) In-Reply-To: References: <4a40a9d140aa477fb34cf5704034bd4c@hhi.fraunhofer.de> From: Paul B Mahol Date: Wed, 11 Jan 2023 12:53:24 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Stoffers, Christian" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/11/23, Paul B Mahol wrote: > On 1/11/23, Helmrich, Christian > wrote: >> Hi, >> >> >>> So its better to use that instead of human written assembly? Does clang >>> generate faster code without this asm? >> >> >> I'm not sure I fully understand your questions, but I hope the following >> answers it. The reason why we auto-converted our intrinsics code to asm >> is >> not a technical one, we unfortunately just don't have the knowledge or >> resources to manually write asm code. If I remember correctly, the SIMD >> optimized code runs about twice as fast as the C code, especially on UHD >> input. > > Compare clang compiled ffmpeg without this asm code and with it, and > tell if any difference. > I'might do it anyway later. Also please fix style of code, look at other filters in codebase, for example vf_psnr.c filter Use "for () {\n" instead of "for () \n{\n}" > >> >> >>> Please remove SLICE_THREADS related flag as there is no call to execute >>> to >>> filter in slices. Please remove stdbool.h header and adapt code to >>> compile >>> without it. >> >> >> Done, please find attached a second version (v1) of the XPSNR avfilter >> patch. >> >> >> Thanks and best, >> >> >> Christian Helmrich >> >> Fraunhofer HHI, Video Coding and Analytics Department >> >> >> ________________________________ >> Von: ffmpeg-devel im Auftrag von Paul B >> Mahol >> Gesendet: Dienstag, 10. Januar 2023 21:43 >> An: FFmpeg development discussions and patches >> Cc: Stoffers, Christian >> Betreff: Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter >> >> On 1/10/23, Helmrich, Christian >> wrote: >>> Hi, >>> >>> please find attached a patch (relative to FFmpeg master as of early >>> January >>> 10, 2023) >>> adding avfilter support for extended perceptually weighted peak >>> signal-to-noise ratio >>> (XPSNR) measurements for videos, as described in the related addition to >>> filters.texi. >>> >>> The XPSNR code was originally vectorized using SIMD intrinsics, but we >>> concluded that >>> FFmpeg code requires asm instead of such intrinsics, so we let gcc >>> auto-convert these >> >> So its better to use that instead of human written assembly? >> Does clang generate faster code without this asm? >> >>> instructions to pure assembly; see the vf_xpsnr.asm file. If the added >>> asm >>> code is too >>> lengthy, intrinsics would be possible, or something else is missing, >>> please >>> let us know. >>> >> >> Please remove SLICE_THREADS related flag as there is no call to >> execute to filter in slices. >> Please remove stdbool.h header and adapt code to compile without it. >> >>> Best, >>> >>> Christian Helmrich and Christian Stoffers >>> Fraunhofer HHI >>> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".