Re: [FFmpeg-devel] [PATCH] avcodec: add PHM decoder and encoder

[Paul B Mahol <onemda@gmail.com>]

On Sat, Jul 2, 2022 at 11:14 AM Anton Khirnov <anton@khirnov.net> wrote:

> Quoting Paul B Mahol (2022-07-01 11:23:20)
> > Hello,
> >
> > patch attached.
> >
> > From cec6259e75fa56a4b064f7d5a0823449d19f3b47 Mon Sep 17 00:00:00 2001
> > From: Paul B Mahol <onemda@gmail.com>
> > Date: Fri, 1 Jul 2022 10:06:15 +0200
> > Subject: [PATCH] avcodec: add PHM decoder and encoder
> >
> > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > ---
> >  libavcodec/Makefile     |   2 +
> >  libavcodec/allcodecs.c  |   2 +
> >  libavcodec/codec_desc.c |   7 +++
> >  libavcodec/codec_id.h   |   1 +
> >  libavcodec/pnm.c        |  10 +++-
> >  libavcodec/pnm.h        |   5 ++
> >  libavcodec/pnm_parser.c |   3 +-
> >  libavcodec/pnmdec.c     | 114 ++++++++++++++++++++++++++++++++++++++++
> >  libavcodec/pnmenc.c     |  75 +++++++++++++++++++++++++-
> >  libavformat/img2.c      |   1 +
> >  libavformat/img2enc.c   |   2 +-
> >  11 files changed, 217 insertions(+), 5 deletions(-)
>
> Please add tests, decoders are useless without them.
>

Thanks you for approval to push this patch.

The test can be trivially added later, in same way as QOI format.


>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".