From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AD5BB44CC1 for ; Mon, 14 Nov 2022 20:58:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2DEE268BA95; Mon, 14 Nov 2022 22:58:33 +0200 (EET) Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8FAF668B773 for ; Mon, 14 Nov 2022 22:58:26 +0200 (EET) Received: by mail-vk1-f171.google.com with SMTP id g26so5606047vkm.12 for ; Mon, 14 Nov 2022 12:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=KKeUst8a092IEAPQIpu7Lzzd7yry98R4rmE01rpCrzc=; b=ZJrHheHEfv8U5ZR4pLCrLBO5FO7mpQyqGYyo9JOvGQyDQTjKPFarFksa8tduCCG4J1 EZ82zj6k0UmweSQ3ndZMBFbluBzY1JpRa8/B0zgHYcpq8NFRfCiBSnzbVYODHiqeL/Uh zCKXu/KkEldlZ30LXsU/a0uij9b2q171mhic0CkIdxSuQYyGULpeCX6erw42wbI320eq 920KjccpPYVf9894Nb4YGI88GVp7wmxxN8xrMGAhFkfcKBtVe81MBmjHaSnaUI9VhqXe SjMfi5F3C3IclJrxcT/UVHbpwqF7Mq43pSi9HAGtbQCdocGRspS1r3bBIFR5zHsM1dfP g/Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KKeUst8a092IEAPQIpu7Lzzd7yry98R4rmE01rpCrzc=; b=Esig4xt0/LsEus1Wf1WjBF3iFkTNhYFy8RU2c0fupKdJHJkxHy4Q/zAbme3IODL+Ox Pyi9FYo1Se9RrDw4WSFu9jdjtFzOyM3jWKk1qi9eQLKLEzaliz+wjKEAg94Xil/nryuL 4kRKPUbmJdZ6jSvYCSuptJt/jmq9ChRpYawvpgU9v4DbeD5BCWLrRjpLs90V+8AUrb5o QFd9k2ksg1yWNWDvt5hCPdFi5dY7YNi9ZBEJQ8f/YvuM9FP5jrtjO+zCfHtuxscsf3xk HBvslhby/6kbQzCbFPuyvckxP02A/z+Z/0LEqyTYv1IZhtsUfvc6xW7oLiXxxX9reRXh tV/Q== X-Gm-Message-State: ANoB5pm6DhWjuvRRQa9N/p6cl+cnv4r908qoFvAqi82hvk5fVr2UVB7k eaHXURzHbhHJfKYE07PPtIc2KcbuZa5V/mUKM1YQyQLz X-Google-Smtp-Source: AA0mqf5PGAuYZrokQGNxzpLm6OUBc8/1noOsg29ZgQqVkck5a1wzcUbMPekYwJCiFyO9p62NzqdkFiRtaROxh9w2MyI= X-Received: by 2002:a05:6122:2304:b0:3b8:42bd:5807 with SMTP id bq4-20020a056122230400b003b842bd5807mr7562228vkb.39.1668459505150; Mon, 14 Nov 2022 12:58:25 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Mon, 14 Nov 2022 12:58:24 -0800 (PST) In-Reply-To: <20221114203232.GH1814017@pb2> References: <20221106123430.1668-1-michael@niedermayer.cc> <20221106123430.1668-3-michael@niedermayer.cc> <20221114203232.GH1814017@pb2> From: Paul B Mahol Date: Mon, 14 Nov 2022 21:58:24 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 3/7] avcodec/bonk: Remove special 32bit case from read_uint_max() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/14/22, Michael Niedermayer wrote: > On Sun, Nov 06, 2022 at 07:28:48PM +0100, Paul B Mahol wrote: >> On 11/6/22, Michael Niedermayer wrote: >> > This case seems not to match the reference decoder and it also >> > seems not reachable >> > >> > Signed-off-by: Michael Niedermayer >> > --- >> > libavcodec/bonk.c | 3 +-- >> > 1 file changed, 1 insertion(+), 2 deletions(-) >> > >> > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c >> > index 04ea4def2f..fca8c246aa 100644 >> > --- a/libavcodec/bonk.c >> > +++ b/libavcodec/bonk.c >> > @@ -136,8 +136,7 @@ static unsigned read_uint_max(BonkContext *s, >> > uint32_t >> > max) >> > if (max == 0) >> > return 0; >> > >> > - if (max >> 31) >> > - return 32; >> > + av_assert0(max >> 31 == 0); >> > >> > for (unsigned i = 1; i <= max - value; i+=i) >> > if (get_bits1(&s->gb)) >> > -- >> > 2.17.1 >> >> >> Not sure, at your risk. >> >> Test lossy mode too. > > piotr provided me with a larger testset including lossy files > they are all unchanged > > will apply this and the other remaining patches. > They look all correct to me, if i am wrong which is always a possibility > iam human ... then you can revert whats wrong of course > Its not for valid, but for fuzzed files. > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > If you drop bombs on a foreign country and kill a hundred thousand > innocent people, expect your government to call the consequence > "unprovoked inhuman terrorist attacks" and use it to justify dropping > more bombs and killing more people. The technology changed, the idea is > old. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".