From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8CE4940FAB for ; Wed, 13 Jul 2022 07:46:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B6FF268B88B; Wed, 13 Jul 2022 10:46:35 +0300 (EEST) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 73FBF68B5F2 for ; Wed, 13 Jul 2022 10:46:29 +0300 (EEST) Received: by mail-yb1-f175.google.com with SMTP id h62so15322216ybb.11 for ; Wed, 13 Jul 2022 00:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=YN6LCfVqTsk/dLsHVfELpSu2l9uSIuud9D5dtNooxGY=; b=PDj0LPnFOK3QTbcvh4ekvejXLfMi4eY+tlz4E8wrgK+zrPdIGOmxcOOS/RFopXbjHI b5NZYKO9aZOrMImJYjtEM13dwaoXmXLTbB+MbrYG+PTYX4oHnPJ5cNvFNDwhJV29KiQ9 5+lAmUT2Z7CzDKDL78nvDIQ5ysMAJU5WKBg7sywyTWyz182pd5N1qGoFnY2OtYwX8+wP kjqKe2tSYa6C0qr0kIY2WmPF+PGhKd8gWBpp9MgrYkNf8V+Aj+fu3M9fmCcBrYiGronB JFz4JDgTrNgOe+M4dspnlN6fifWlGVJpBXNfwOHO39bpxSTwM6aoH5QL8uwsVCG4qt3K aD5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=YN6LCfVqTsk/dLsHVfELpSu2l9uSIuud9D5dtNooxGY=; b=7WhFQ8sj4CL0MLYBLzTvxTm28UuZzBFjZ7xU8VFhvSh2WCFkpqHIy+MieQNaUNEuEk ySlegqnz1OP74P9NqRxyjYJuN0pUCPLJ3Z0eVMrogKPvFhHkm19c9gyy5FKI/WTls3cc cdQTJ2Ij6NY7XJfvvxR0Q/ahAa+qMF8WeHnpsv7n8wJj68YJExhL/qIxWX79e6w03Yxc BjQK+pmREwdD7GrCAPlw9dQ+JIAabV7xbrPy0zM0dABrKNz0WFaVqlC5/9mLBzXNUa/t IVDfxjLWMYC/LOirPDr2h2c+QOnEfsCv8oUBNv3OAdKFEyxT4Kl3Rs7uNcol+EpKOltp 84xw== X-Gm-Message-State: AJIora9h3jTxAS/ZTR/cobY4s0exW+MKSNGRqRjVbfEQdroHJR4eO9lx 1hQuJLsGbNmnZi1o4/bQPH0UKuCIp/yDA1vR1fM67aWk X-Google-Smtp-Source: AGRyM1uSjGJoGfP1WS6SD9lON7JpyDHNNDSgNt6DxmA1jLizxT24DeneQjltZIF66YY1y20XPAaWFtYFyiSPCR2vPns= X-Received: by 2002:a5b:f8e:0:b0:66e:3b1b:813f with SMTP id q14-20020a5b0f8e000000b0066e3b1b813fmr2272103ybh.571.1657698387340; Wed, 13 Jul 2022 00:46:27 -0700 (PDT) MIME-Version: 1.0 References: <20220712184322.22814-1-michael@niedermayer.cc> In-Reply-To: <20220712184322.22814-1-michael@niedermayer.cc> From: Paul B Mahol Date: Wed, 13 Jul 2022 09:49:05 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/lagarith: Check dst/src in zero run code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jul 12, 2022 at 8:43 PM Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 48799/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LAGARITH_fuzzer-4764457825337344 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by > : > Michael Niedermayer > --- > libavcodec/lagarith.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/lagarith.c b/libavcodec/lagarith.c > index 3aeb1c8a99..00e8005222 100644 > --- a/libavcodec/lagarith.c > +++ b/libavcodec/lagarith.c > @@ -409,6 +409,9 @@ output_zeros: > if (zero_run) { > zero_run = 0; > i += esc_count; > + if (i > end - dst || > + i >= src_end - src) > + return AVERROR_INVALIDDATA; > memcpy(dst, src, i); > dst += i; > l->zeros_rem = lag_calc_zero_run(src[i]); > LGTM > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".