From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()
Date: Fri, 4 Mar 2022 23:49:38 +0100
Message-ID: <CAPYw7P6TYxAz69Ra+ad2rdMOBaPEmJitd4NdGG9YuEoH2T9T5Q@mail.gmail.com> (raw)
In-Reply-To: <YiIQXZtIB5LCujIa@phare.normalesup.org>
On 3/4/22, Nicolas George <george@nsup.org> wrote:
> Paul B Mahol (12022-03-03):
>> It is caused by number of sample per frame.
>>
>> I tested actually with -f lavfi -i sine only.
>>
>> And patch resolves issue.
>
> I do not doubt it does. But even without activate, EOF should not depend
> on the number of samples per frame. There is something wrong going on
> there, and I want to understand what before this change makes it go
> away: otherwise, we might be missing other similar bugs.
>
> It has waited several months, a few days more will not hurt.
>
No, wait must stop.
The issue is that EOF is never reported if there is >1 frame left in
queue before EOF for filters that do not use .activate (and use >1
inputs).
> Regards,
>
> --
> Nicolas George
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-04 22:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 13:27 Paul B Mahol
2022-03-03 18:30 ` Nicolas George
2022-03-03 20:58 ` Paul B Mahol
2022-03-04 13:13 ` Nicolas George
2022-03-04 22:49 ` Paul B Mahol [this message]
2022-03-05 11:04 ` Nicolas George
2022-03-05 12:56 ` Paul B Mahol
2022-03-05 19:37 ` Nicolas George
2022-03-06 14:08 ` Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPYw7P6TYxAz69Ra+ad2rdMOBaPEmJitd4NdGG9YuEoH2T9T5Q@mail.gmail.com \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git