From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 72D2540F8A for ; Mon, 14 Mar 2022 12:15:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C5A8468B13D; Mon, 14 Mar 2022 14:15:30 +0200 (EET) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7B88668A717 for ; Mon, 14 Mar 2022 14:15:24 +0200 (EET) Received: by mail-yb1-f173.google.com with SMTP id u10so30255912ybd.9 for ; Mon, 14 Mar 2022 05:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=1OnFaCJHufd0hk4FjzcveLXGKupncjeMAUIx3HzGFns=; b=k/Llc2GCzTbjbazn9pnsHJ9ca6wZg8VTm9CY3NVMl7Gp321CmlsZtXwYQsIEgdTZ26 +b/Eo/UkITwyRakt8BcK8ZWb/I5Nx442TtbjHsag5DGwRm7pBb9+PuIW97mg5MvS71MW NamR90l7RJFcDX3RVP+guHecsixAB5+AC6h4Y6mENC3SMY1SqkwlL42nChYVRfzrbieP b5B1LKJwc2gRynj3OrQ8FJc17C+EhmmuDbT8bNn183zETqgmoLaRsf3MT59jxQuSFFiY T3E8PHLeHeDlv/uq6iiI5V1X/qG/3Nq+d2O4XOBYRmTKp49QQ2sN/2SxmDGNQJ7rbosA 91mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=1OnFaCJHufd0hk4FjzcveLXGKupncjeMAUIx3HzGFns=; b=09tQppLZyuj8zpx5RqeHiAi9C+T/fqAWiQfjQocmWHoBKS8JwKaiNnH9qlO89AfAq5 e7+pccMWhULR/8RX9i7tqo3s4dpPNWc7Z/EaWgjpKw3Ze6Xdg/ztfYsXyVA/R2+bd5JM wltJBMmvQcgOJZ5/fVPzyiPls2alswZ0mSU8KqILto2oKA1IiHgtiYNFUsSsodmy/XIu A493zfAAzqv7/6aRi8A1fc4NpkGOmRt7q61UUcbnn3FKKcDsvE+/iOitOgcc/SgBBCMq SGU7NJOucBX7tgkfwUJNfyXjLQ11bQSTyPjSWWxmcZdZddvZfnuc25txNRODRGQqXd29 f1sw== X-Gm-Message-State: AOAM530A+z3sLhSXD+tXv8TaLA4t5R13Sr1OKdqrLOFhLOMrE9ifdrHV KvCznj8lyddtWsswtfiS5Wa3lLfIF1RpAi6Y1epLqDn0 X-Google-Smtp-Source: ABdhPJwrqDsBCWu8DlnGDtAsg2xxJZ/AH01qafdHDcNqbhW3JXLCOBkQsOsfG89hL49B2NbMCrB0FwTAkn8VoOHoWnc= X-Received: by 2002:a25:409:0:b0:628:7631:63bb with SMTP id 9-20020a250409000000b00628763163bbmr17419406ybe.250.1647260123063; Mon, 14 Mar 2022 05:15:23 -0700 (PDT) MIME-Version: 1.0 References: <20220314115602.263642-1-onemda@gmail.com> <4932f52a-3df7-525f-22cc-a5ccfa34f6e4@gmail.com> In-Reply-To: <4932f52a-3df7-525f-22cc-a5ccfa34f6e4@gmail.com> From: Paul B Mahol Date: Mon, 14 Mar 2022 13:17:11 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add null encoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Mar 14, 2022 at 1:12 PM James Almer wrote: > > > On 3/14/2022 8:56 AM, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/Makefile | 2 ++ > > libavcodec/allcodecs.c | 2 ++ > > libavcodec/codec_desc.c | 14 ++++++++++ > > libavcodec/codec_id.h | 2 ++ > > libavcodec/nullenc.c | 61 +++++++++++++++++++++++++++++++++++++++++ > > 5 files changed, 81 insertions(+) > > create mode 100644 libavcodec/nullenc.c > > > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > > index cd929da8e6..8554b5ee7d 100644 > > --- a/libavcodec/Makefile > > +++ b/libavcodec/Makefile > > @@ -542,6 +542,8 @@ OBJS-$(CONFIG_MXPEG_DECODER) += mxpegdec.o > > OBJS-$(CONFIG_NELLYMOSER_DECODER) += nellymoserdec.o nellymoser.o > > OBJS-$(CONFIG_NELLYMOSER_ENCODER) += nellymoserenc.o nellymoser.o > > OBJS-$(CONFIG_NOTCHLC_DECODER) += notchlc.o > > +OBJS-$(CONFIG_NULL_AUDIO_ENCODER) += nullenc.o > > +OBJS-$(CONFIG_NULL_VIDEO_ENCODER) += nullenc.o > > OBJS-$(CONFIG_NUV_DECODER) += nuv.o rtjpeg.o > > OBJS-$(CONFIG_ON2AVC_DECODER) += on2avc.o on2avcdata.o > > OBJS-$(CONFIG_OPUS_DECODER) += opusdec.o opus.o opus_celt.o > opus_rc.o \ > > diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c > > index 628d27fd75..a30920bfe2 100644 > > --- a/libavcodec/allcodecs.c > > +++ b/libavcodec/allcodecs.c > > @@ -487,6 +487,8 @@ extern const AVCodec ff_mpc8_decoder; > > extern const AVCodec ff_msnsiren_decoder; > > extern const AVCodec ff_nellymoser_encoder; > > extern const AVCodec ff_nellymoser_decoder; > > +extern const AVCodec ff_null_audio_encoder; > > +extern const AVCodec ff_null_video_encoder; > > extern const AVCodec ff_on2avc_decoder; > > extern const AVCodec ff_opus_encoder; > > extern const AVCodec ff_opus_decoder; > > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > > index 81f3b3c640..7d6bfd352c 100644 > > --- a/libavcodec/codec_desc.c > > +++ b/libavcodec/codec_desc.c > > @@ -3516,6 +3516,20 @@ static const AVCodecDescriptor > codec_descriptors[] = { > > .long_name = NULL_IF_CONFIG_SMALL("AVFrame to AVPacket > passthrough"), > > .props = AV_CODEC_PROP_LOSSLESS, > > }, > > + { > > + .id = AV_CODEC_ID_AUDIO_NULL, > > + .type = AVMEDIA_TYPE_AUDIO, > > + .name = "null_audio", > > + .long_name = NULL_IF_CONFIG_SMALL("Audio NULL"), > > + .props = AV_CODEC_PROP_LOSSY, > > + }, > > + { > > + .id = AV_CODEC_ID_VIDEO_NULL, > > + .type = AVMEDIA_TYPE_VIDEO, > > + .name = "null_video", > > + .long_name = NULL_IF_CONFIG_SMALL("Video NULL"), > > + .props = AV_CODEC_PROP_LOSSY, > > Also AV_CODEC_PROP_INTRA_ONLY on both. > > > + }, > > }; > > > > static int descriptor_compare(const void *key, const void *member) > > diff --git a/libavcodec/codec_id.h b/libavcodec/codec_id.h > > index 3ffb9bd22e..4822dc7685 100644 > > --- a/libavcodec/codec_id.h > > +++ b/libavcodec/codec_id.h > > @@ -571,6 +571,8 @@ enum AVCodecID { > > * stream (only used by libavformat) */ > > AV_CODEC_ID_FFMETADATA = 0x21000, ///< Dummy codec for streams > containing only metadata information. > > AV_CODEC_ID_WRAPPED_AVFRAME = 0x21001, ///< Passthrough codec, > AVFrames wrapped in AVPacket > > + AV_CODEC_ID_AUDIO_NULL = 0x21002, ///< Null audio codec > > + AV_CODEC_ID_VIDEO_NULL = 0x21003, ///< Null video codec > > }; > > > > /** > > diff --git a/libavcodec/nullenc.c b/libavcodec/nullenc.c > > new file mode 100644 > > index 0000000000..8d3553ed33 > > --- /dev/null > > +++ b/libavcodec/nullenc.c > > @@ -0,0 +1,61 @@ > > +/* > > + * Copyright (c) 2022 The FFmpeg Project > > + * > > + * This file is part of FFmpeg. > > + * > > + * FFmpeg is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2.1 of the License, or (at your option) any later version. > > + * > > + * FFmpeg is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with FFmpeg; if not, write to the Free Software > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > 02110-1301 USA > > + */ > > + > > +#include "libavutil/internal.h" > > +#include "libavutil/frame.h" > > +#include "libavutil/buffer.h" > > + > > +#include "avcodec.h" > > +#include "internal.h" > > +#include "encode.h" > > + > > +static int null_encoder(AVCodecContext *avctx, AVPacket *pkt, > > + const AVFrame *frame, int *got_packet) > > +{ > > + int ret; > > + > > + pkt->pts = frame->pts; > > + if (avctx->codec_type == AVMEDIA_TYPE_AUDIO) > > + pkt->duration = ff_samples_to_time_base(avctx, > frame->nb_samples); > > + pkt->flags |= AV_PKT_FLAG_KEY; > > + if ((ret = ff_alloc_packet(avctx, pkt, 1)) < 0) > > To avoid bogus statistics, could you instead allocate a blank packet of > size av_samples_get_buffer_size()? > Also, use ff_get_encode_buffer() and set the DR1 codec cap. > > > + return ret; > > + *got_packet = 1; > > + return 0; > > +} > > + > > +const AVCodec ff_null_video_encoder = { > > + .name = "null_video", > > + .long_name = NULL_IF_CONFIG_SMALL("Video NULL encoder"), > > + .type = AVMEDIA_TYPE_VIDEO, > > + .id = AV_CODEC_ID_VIDEO_NULL, > > + .encode2 = null_encoder, > > + .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE, > > +}; > > + > > +const AVCodec ff_null_audio_encoder = { > > + .name = "null_audio", > > + .long_name = NULL_IF_CONFIG_SMALL("Audio NULL encoder"), > > + .type = AVMEDIA_TYPE_AUDIO, > > + .id = AV_CODEC_ID_AUDIO_NULL, > > + .encode2 = null_encoder, > > + .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE, > > + .capabilities = AV_CODEC_CAP_VARIABLE_FRAME_SIZE, > > What's the benefit from this? If the idea is to get rid of > wrappedavframe, then you also need to fix vapoursync, decklink, kmsgrab, > opengl, xv, and yuv4mpeg. > > I'd rather not add more fake codec ids for this purpose unless it's a > thorough solution. > See null muxer patch. null muxer does not need pcm codecs or wrapped video codec. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".