From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AD12244B7B for ; Sun, 6 Nov 2022 18:30:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D4BAB68B995; Sun, 6 Nov 2022 20:30:32 +0200 (EET) Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BDB9368B8AF for ; Sun, 6 Nov 2022 20:30:26 +0200 (EET) Received: by mail-vk1-f182.google.com with SMTP id i15so5355645vka.0 for ; Sun, 06 Nov 2022 10:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=TA++qj8Ou1rFx96ocMJcFS8/lj4YPflCEPIMOQMxJuc=; b=LSqKKcn61wO3Usj4OgCnhQB7mNhrZuwIzibH6ogR+YyrjlcbawBpa2uO5CWFhF0Muq etvQQ+4hSVqme0bhb6ky5VCeiT02JhPNDGaMX1tp18X1qGQ13pzzTbRio1oClfvhAVkv EF8JNGMxWxpXtPuqNy/jm9dHG1LNKhq6pCsdF7xgHJWfq62C7ufYoDvJhaF15AtPCz8N FNcQvIA/pYSASSFCAoeGBFHhwHfKAsmAuDNrXlnFmTRwWv4A/kfVA7xn4+J02zN/CceE T7b6N3NTp13qAU/nIdfu8FN/J49udGpkpf9jfjpZpc3MGdUiFDelsNLqlx5U9o8Dq7Oo k7tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TA++qj8Ou1rFx96ocMJcFS8/lj4YPflCEPIMOQMxJuc=; b=XgxcarVxNZGFlw+6CV247lksxslAqq/a9531UUBXnx9nlNhHZhRucFVGd4pg7DvT52 fod7/htdavDY3ASEht/2gRmZCMdNRCzoq2LrQydCQKbWh5eggk+JGb5SbaB/gllFTxcD XSo4Y7RzaUaRrXfhs1VJpI3/kjoMu44bNNN6cjaKCcCTQkO1c42H3OOrWUV4RsV1Iwsv LaHNK4lGxSC7lPyTZ29QsPkvK4QQQKh7UPL6x+FMvr3lcYPBq7GI2Ax0rxG2bC/+dfDe uycDYHBhRoV6HI/Lql/ruRK9cFVUurQkmpRsAn9xLg1yFEZqWbjDaAbJtcvvZBoRCc2j RzqQ== X-Gm-Message-State: ACrzQf1LcfeoeT+A9G+VOWyUqzbqjWuqSPJ0BqVOqoPBXfrBqb/IlKpH kOb7nPI9dZQb9T8dSTAhuyesPsEAjDXK/TA+ovvGIjJF X-Google-Smtp-Source: AMsMyM7twjw+Q9hTrPuJn2M1vkSrhNFOo/Qha3b3rysppkDIUhhiGLZ3BsxiTH3c26GxaFBCRyRua4tTwUUMKElXgz8= X-Received: by 2002:a05:6122:16a9:b0:3b8:993c:2bb6 with SMTP id 41-20020a05612216a900b003b8993c2bb6mr4622748vkl.21.1667759425455; Sun, 06 Nov 2022 10:30:25 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:612:b0:314:ac6a:1eb7 with HTTP; Sun, 6 Nov 2022 10:30:24 -0800 (PST) In-Reply-To: <20221106123430.1668-2-michael@niedermayer.cc> References: <20221106123430.1668-1-michael@niedermayer.cc> <20221106123430.1668-2-michael@niedermayer.cc> From: Paul B Mahol Date: Sun, 6 Nov 2022 19:30:24 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/7] avcodec/bonk: Simplify read_uint_max() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/6/22, Michael Niedermayer wrote: > The max == 0 case can be removed too but i left it as 50% of the cases use > it > > Signed-off-by: Michael Niedermayer > --- > libavcodec/bonk.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > index 9e8892e4db..04ea4def2f 100644 > --- a/libavcodec/bonk.c > +++ b/libavcodec/bonk.c > @@ -132,7 +132,6 @@ static av_cold int bonk_init(AVCodecContext *avctx) > static unsigned read_uint_max(BonkContext *s, uint32_t max) > { > unsigned value = 0; > - int i, bits; > > if (max == 0) > return 0; > @@ -140,15 +139,9 @@ static unsigned read_uint_max(BonkContext *s, uint32_t > max) > if (max >> 31) > return 32; > > - bits = 32 - ff_clz(max); > - > - for (i = 0; i < bits - 1; i++) > - if (get_bits1(&s->gb)) > - value += 1 << i; > - > - if ((value | (1 << (bits - 1))) <= max) > + for (unsigned i = 1; i <= max - value; i+=i) > if (get_bits1(&s->gb)) > - value += 1 << (bits - 1); > + value += i; > > return value; > } > -- > 2.17.1 > probably ok. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".