From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AE8C946564 for ; Sun, 21 May 2023 18:00:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 56CFC68C005; Sun, 21 May 2023 21:00:07 +0300 (EEST) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 430B868BBA2 for ; Sun, 21 May 2023 21:00:01 +0300 (EEST) Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-436175b038fso1636714137.3 for ; Sun, 21 May 2023 11:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684692000; x=1687284000; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=wFhFJrqp1Fxn/nF7wMkgF0jHngFoZM9XfaWKwJKo8iA=; b=VX4FkQJMz083SbJs12MyCKMEPoowyCf+b5Zgkcv6RTmmVP6LgRHk31MVJlaZAdAtJt Gc6XbQpQxlY1izwkRxK5UnChG2Ppg39rE9aCaD4BeD40eRzdgd7Jyn3ij2a65Y/yqTj3 93d1slC29JTBKcaAcl9y7H9lraa2vggNcIj1lNU9mXVSTBnrqi3qHoBwuEuXoViXH0wA bThvn6ZWlz8Pff74/mij+ScsqK1N5USHqesO8BiVmG+tekcwxrPbbjirk4CxUG/6sPaw 5ly0591L+S+4gl84HtMs9ysdxbtcupOo2lcMuqz0uRvEErENvtN8bKDMgJVKrDQpC+Le w4ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684692000; x=1687284000; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wFhFJrqp1Fxn/nF7wMkgF0jHngFoZM9XfaWKwJKo8iA=; b=Pw68z+ljtoxWJZQd5tgpcL4k+GRQDwmhMoSz4X+K4CY3KT+omn8scwAWqzglObyN+x pyYku/CuJrD3xWQgvdh5h/lC3vALw7w1GfEtzgh9V4MxhHT6Vq7OcicGKPKqwqsaQTQx aIbFSmvnGiTpsSuHNTR7V/883RbtddqyRTf5f7T9YJV6L+Cx5RWjUZexrl/EqDSJw984 mzA45f6I+C0mBkQiy9uID0CerZVL5y/Iy/aTG8iPUnfaNsLSFH12ak8Cr5NJtH2LNzD6 Zlj4Zy0bnpdqNw6bsa3VmPhNKMbQMC+3VSlKNeS+DgGteMY8HNPvdtBO9XhRDBCQ4wwh NsWw== X-Gm-Message-State: AC+VfDzzB8kgLdye58ZtakjuQVG5zw39x1oWctKutSJAteF/EYSRi+lj IG1tpGydCib1YAZvQkEna9l01kvj8YYLvEUHmIuEXpG7 X-Google-Smtp-Source: ACHHUZ7phkbeBNSGW0TfxDNxdKUEEuww1VVjr4a06Fabuc8XSfNZ/yCnip6JQHVvn7s+7HoyXWb0Q0R37VoEjxJyXBY= X-Received: by 2002:a67:fc95:0:b0:436:105d:91f9 with SMTP id x21-20020a67fc95000000b00436105d91f9mr1929412vsp.21.1684691999730; Sun, 21 May 2023 10:59:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a59:cd03:0:b0:3b6:f9a0:5488 with HTTP; Sun, 21 May 2023 10:59:58 -0700 (PDT) In-Reply-To: <20230521173647.GG1391451@pb2> References: <20230521173647.GG1391451@pb2> From: Paul B Mahol Date: Sun, 21 May 2023 19:59:58 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/21/23, Michael Niedermayer wrote: > On Sun, May 21, 2023 at 01:24:06PM +0200, Paul B Mahol wrote: >> libavcodec/gifdec.c | 11 - >> libavformat/gifdec.c | 245 +++++------------------ >> tests/ref/fate/gif-color | 348 >> ++++++++++++++++----------------- >> tests/ref/fate/gif-deal | 314 >> +++++++++++++++++++++++++++-- >> tests/ref/fate/gif-disposal-background | 12 - >> tests/ref/fate/gif-disposal-restore | 6 >> tests/ref/fate/gifenc-bgr4_byte | 348 >> ++++++++++++++++----------------- >> tests/ref/fate/gifenc-bgr8 | 348 >> ++++++++++++++++----------------- >> tests/ref/fate/gifenc-gray | 348 >> ++++++++++++++++----------------- >> tests/ref/fate/gifenc-pal8 | 348 >> ++++++++++++++++----------------- >> tests/ref/fate/gifenc-rgb4_byte | 348 >> ++++++++++++++++----------------- >> tests/ref/fate/gifenc-rgb8 | 348 >> ++++++++++++++++----------------- >> 12 files changed, 1585 insertions(+), 1439 deletions(-) >> a8f54d72293f55ac76ae2e004e57809d7e9b90c6 >> 0003-avformat-gifdec-switch-to-using-gif-parser.patch >> From 866801d43a9cf4c90e86afde1963b8b684e92998 Mon Sep 17 00:00:00 2001 >> From: Paul B Mahol >> Date: Sat, 20 May 2023 14:13:27 +0200 >> Subject: [PATCH 3/3] avformat/gifdec: switch to using gif parser >> >> Update fate, more correct as timebase is not reduced. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/gifdec.c | 11 +- >> libavformat/gifdec.c | 245 +++++------------ >> tests/ref/fate/gif-color | 348 ++++++++++++------------- >> tests/ref/fate/gif-deal | 314 ++++++++++++++++++++-- >> tests/ref/fate/gif-disposal-background | 12 +- >> tests/ref/fate/gif-disposal-restore | 6 +- >> tests/ref/fate/gifenc-bgr4_byte | 348 ++++++++++++------------- >> tests/ref/fate/gifenc-bgr8 | 348 ++++++++++++------------- >> tests/ref/fate/gifenc-gray | 348 ++++++++++++------------- >> tests/ref/fate/gifenc-pal8 | 348 ++++++++++++------------- >> tests/ref/fate/gifenc-rgb4_byte | 348 ++++++++++++------------- >> tests/ref/fate/gifenc-rgb8 | 348 ++++++++++++------------- >> 12 files changed, 1585 insertions(+), 1439 deletions(-) > > breaks:fate-fits-demux > ... > +0, 242, 242, 1, 14320, 0xa34e7331 > +0, 243, 243, 1, 14320, 0xa34e7331 > +0, 244, 244, 1, 14320, 0xa34e7331 > +0, 245, 245, 1, 14320, 0xa34e7331 > +0, 246, 246, 1, 14320, 0xa34e7331 > +0, 247, 247, 1, 14320, 0xa34e7331 > +0, 248, 248, 1, 14320, 0xa34e7331 > +0, 249, 249, 1, 14320, 0xa34e7331 > Test fits-demux failed. Look at tests/data/fate/fits-demux.err for details. > tests/Makefile:307: recipe for target 'fate-fits-demux' failed > make: *** [fate-fits-demux] Error 1 > > That is actually more correct output. Previously it would drop most of the available frames. > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Many that live deserve death. And some that die deserve life. Can you give > it to them? Then do not be too eager to deal out death in judgement. For > even the very wise cannot see all ends. -- Gandalf > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".