From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6DBDD4362A for ; Sat, 17 Sep 2022 14:46:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3032668BB9B; Sat, 17 Sep 2022 17:46:01 +0300 (EEST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C1D7E68BB34 for ; Sat, 17 Sep 2022 17:45:54 +0300 (EEST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-349c4310cf7so126321757b3.3 for ; Sat, 17 Sep 2022 07:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date; bh=lRTzfzpAX/woqM/UkAQf5oX1I+43rPXEKGcQs8F4bo0=; b=SYi/GH01uuHUW+icpsqgOHZsfvIkbJ6iIFgPJx3uqLREmcBC3I//fYTAKkDu1Xur+3 pcFdjwzTAdq2hPpaAY/f0WGk2aKSJx2UAuz+v2NxyohycX0An7rjrIivUwDdmjfyuJCI 25Ire9wlfiP2l33b1SiOVmmQQnF5c8uH/cj3C9aUpkEXIT8MztTcZqxHwbrGDgpUDUyx Recj87teIk6VqdqhbXJXtp/zVEiflVbm/mAy+mAt2EyEbfH39K4Lf3SKG5nVUPNe2b8d tvleVM9ZsNK/PyT6AhdP2DaO9RNSO3GVvGk4hKM14MDlqCKSNFmA4PRZ5zPJB5yp4zcJ /MRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=lRTzfzpAX/woqM/UkAQf5oX1I+43rPXEKGcQs8F4bo0=; b=bUbVtZJB5iW0oUgwTidY5ka+b4lNeouBpiITGYuZDMqa6AVl292ZybKq+8ZaG3dq2y MJSJ19LhIuR1Fw4p5Bnx+RYEZM531va1MxEKjH1/2ZqQlQpt7D/7qRXYlTW4c4HJ6S+f aQ1+ZrzLne+4KVgNtShZpUQQhvavU57X59GoYFn8L4lGm8vcq/zs0KxJrYYRCCy2XnJN J0rlRhnWk9E7Jgn9EFdzwipNfm0lSaWkrjLFWUOTFC6bgncR1ynzl8sIM3hz84deq1Io rudhaL+/mjRquMlt15nWXkpw+yzJ1FUtie5t2WNgpep8RMbuny5fQnNa24oFWnZcd3D2 Q8ZA== X-Gm-Message-State: ACrzQf1IonRvD+pTriO0DCSNXJtXWREQR/8Uol9pfNTZw89sriM2wfex yK53cscYitX1zJY4hbfp/njCAoHzPHk61P9rHyszujPM X-Google-Smtp-Source: AMsMyM6U4aqDON+FenEqLnZS993JWxu/YsL6qq1352nBr4+8kHP8OJvKqV1KrI7vu5GWLXm3FXirfKJV7XsS4hSD2cI= X-Received: by 2002:a81:b09:0:b0:345:30d:77b7 with SMTP id 9-20020a810b09000000b00345030d77b7mr8237743ywl.177.1663425953218; Sat, 17 Sep 2022 07:45:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:7402:0:0:0:0:0 with HTTP; Sat, 17 Sep 2022 07:45:52 -0700 (PDT) In-Reply-To: <20220917143209.7797-1-michael@niedermayer.cc> References: <20220917143209.7797-1-michael@niedermayer.cc> From: Paul B Mahol Date: Sat, 17 Sep 2022 16:45:52 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/aiffdec: Check block_duration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/17/22, Michael Niedermayer wrote: > Fixes: signed integer overflow: 3 * -2147483648 cannot be represented in > type 'int' > Fixes: > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6668935979728896 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/aiffdec.c | 2 ++ > 1 file changed, 2 insertions(+) > LGTM > diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c > index 0487d3f0299..318e3ad742e 100644 > --- a/libavformat/aiffdec.c > +++ b/libavformat/aiffdec.c > @@ -372,6 +372,8 @@ got_sound: > av_log(s, AV_LOG_ERROR, "could not find COMM tag or invalid > block_align value\n"); > return AVERROR_INVALIDDATA; > } > + if (aiff->block_duration < 0) > + return AVERROR_INVALIDDATA; > > /* Now positioned, get the sound data start and end */ > avpriv_set_pts_info(st, 64, 1, st->codecpar->sample_rate); > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".