Re: [FFmpeg-devel] [PATCH 1/5] avutil/tx_template: extend to 2M

[Paul B Mahol <onemda@gmail.com>]

On Mon, Jul 24, 2023 at 8:46 PM Tomas Härdin <git@haerdin.se> wrote:

> mån 2023-07-24 klockan 10:57 +0200 skrev Paul B Mahol:
> > On Mon, Jul 24, 2023 at 10:34 AM Andreas Rheinhardt <
> > andreas.rheinhardt@outlook.com> wrote:
> >
> > > Michael Niedermayer:
> > > > On Sat, Jun 17, 2023 at 12:20:44AM +0200, Michael Niedermayer
> > > > wrote:
> > > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > > > ---
> > > > >  libavutil/tx_template.c | 12 ++++++++++++
> > > > >  1 file changed, 12 insertions(+)
> > > >
> > > > will apply patches 1-4
> > > > (this should reduce the differences in the avradio repository in
> > > libavcodec/libavutil)
> > > >
> > >
> > > I actually wanted to complain about this; but then I saw that it
> > > had
> > > already been applied. Before that, I believed that this patchset
> > > was
> > > meant to be applied to the fork only and therefore didn't give it
> > > any
> > > scrutiny. These patches should have only been applied after the
> > > decision
> > > to merge the fork.
> > >
> > > I am against applying patches to simplify maintaining a fork. E.g.
> > > I am
> > > against further avpriv functions (but not absolutely) like you
> > > added in
> > > 4/5. Your patches are even very suboptimal in this regard: You
> > > added two
> > > avpriv functions, yet only one of them (the non-fixed-point) is
> > > used by
> > > your fork. Furthermore, you only need these 2MB windows for floats,
> > > not
> > > for int or doubles.
> > >
> > >
> > I need this, and only this patch to stay in tree.
>
> For what? avfilter stuff?
>

This or alternative solution, I think Lynne is working on it....


>
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".