From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1654644B64 for ; Sun, 6 Nov 2022 18:26:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 87BF568B8BF; Sun, 6 Nov 2022 20:26:49 +0200 (EET) Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AE8D1680105 for ; Sun, 6 Nov 2022 20:26:43 +0200 (EET) Received: by mail-vk1-f178.google.com with SMTP id r13so3646274vkf.2 for ; Sun, 06 Nov 2022 10:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=43jhdaxRjTikyYPr7HQlEgVGoai2JRZkqesZVs/mJwk=; b=aYhh7sbwvqN5591yEc+388EDeWFRgmM2GZFCV13lhLIPxOJ68kDZIu5si7XOquJ5Gh sL3ZWJizYQMlA5DwVdDt6zmopbv3O9ZvG9Zb0z3pLP2xLtbmrr0wZBuTaJ2kF0G3ZB0c +Tvh8QYdyDGDPDVRyNsX2QTICe5GSrp1PfLoAWmmzLG+G2dr+oTA0zdAK7xzP783PW86 HaT2bAJyg8iqmObVi+AW3JcEavEDF4CQ237Udf7WFY2OtvphXWKqSf3TN1DKpWXNfhAn IIiAJvx5pgRfczHc0xpPI3hWslOI8eBNJW3Dg+ABsm+tFCxnEpLa1EytC+jxcjGU3Sn5 39kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=43jhdaxRjTikyYPr7HQlEgVGoai2JRZkqesZVs/mJwk=; b=Fhc5r77agqzGYdqUsQVZkQGSn6Vst2j8qNeE2PVJq2YC3d6JGBET6L33s5mrlhHt6q KKPpa8OktY0FiFAexFFRRBtfJrAIdLwvkHVnKyzncEln4SAImX7KqH5ph8X+8pZMA/o7 UnKTbfQzvAXdcnHAwxvzAfW3RXJZPqSZX/EJobeecNIw/0itEWNXXCuHRqu/xqt7DP8x mLR6OAvrTc4Apy3hx8ZFcByLNLJzoUH6TAx4eC/+c3MFWmSOLy+yaWqjiLPnt/ElqiSX qPEdw70nbJILyz+yf69r9Ox7isIx9vF+v661eGLgcNbvA7KoqzOUxRJJ9m+SowqnhBa3 wQRA== X-Gm-Message-State: ACrzQf099R/pVf4f84/7XCvF+cQjVTEOLavDD2bzvoSlHZW4cd698z37 ySWWrn95K9NANaBCpJmmjpVhDB2LLJX7YySGckQ1o9tf X-Google-Smtp-Source: AMsMyM4fnr5BngEj8EfNgXs752f4cL1ovt0IcXCNpbguObK0iz/uwxTXSIrCXf0iwpTZ1BP8WOEvyH5kixjc8qZpIMQ= X-Received: by 2002:a1f:c1d2:0:b0:3b4:a675:4346 with SMTP id r201-20020a1fc1d2000000b003b4a6754346mr24032055vkf.39.1667759202225; Sun, 06 Nov 2022 10:26:42 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:612:b0:314:ac6a:1eb7 with HTTP; Sun, 6 Nov 2022 10:26:41 -0800 (PST) In-Reply-To: <20221106123430.1668-5-michael@niedermayer.cc> References: <20221106123430.1668-1-michael@niedermayer.cc> <20221106123430.1668-5-michael@niedermayer.cc> From: Paul B Mahol Date: Sun, 6 Nov 2022 19:26:41 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 5/7] avcodec/bonk: step cannot become 0 without overflowing which is undefined X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/6/22, Michael Niedermayer wrote: > also the original reference code does not contain a 0 check > > Signed-off-by: Michael Niedermayer > --- > libavcodec/bonk.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > index 99dac0b951..37ad7854b6 100644 > --- a/libavcodec/bonk.c > +++ b/libavcodec/bonk.c > @@ -203,8 +203,6 @@ static int intlist_read(BonkContext *s, int *buf, int > entries, int base_2_part) > } > > if (step < 256) { > - if (step == 0) > - return AVERROR_INVALIDDATA; > step = 65536 / step; > dominant = !dominant; > } > -- > 2.17.1 > Not sure, at your risk. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".