Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

[Paul B Mahol <onemda@gmail.com>]

On Thu, Nov 30, 2023 at 8:39 PM Kyle Swanson <k@ylo.ph> wrote:

> Hi,
>
> On Thu, Nov 30, 2023 at 6:11 AM Paul B Mahol <onemda@gmail.com> wrote:
> >
> > I tested this a lot, and its great move forward.
> >
> > Make more useful testing and review next time, I'm sure you are quite
> > capable person.
>
> Paul, I agree with Anton. Refactoring the code (i.e. changing filter
> behavior) and combining it with f_ebur128.c all at once makes the diff
> very hard to review. I suggest an incremental approach, let's address
> the issues you've identified with the loudnorm filter one by one, and
> then a second stage where we see about combining with f_ebur128.c.
>

Loudnorm filter is big pile of hacks, I wanted to move forward and I
improved it.

I received nothing in return just some politics talks.

I will apply this soon unless technical comments arise.

Why would I spend on this more my precious time? For no real gain as I will
again
receive nothing in return except some useless comment and no single
technical aspect.



>
> Thanks,
> Kyle
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".