Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

[Paul B Mahol <onemda@gmail.com>]

On Thu, Nov 30, 2023 at 2:57 PM Anton Khirnov <anton@khirnov.net> wrote:

> Quoting Paul B Mahol (2023-11-30 15:01:23)
> > On Thu, Nov 30, 2023 at 2:47 PM Anton Khirnov <anton@khirnov.net> wrote:
> >
> > > Quoting Paul B Mahol (2023-11-30 13:48:16)
> > > > On Thu, Nov 30, 2023 at 12:43 PM Anton Khirnov <anton@khirnov.net>
> > > wrote:
> > > >
> > > > > Quoting Paul B Mahol (2023-11-28 17:51:14)
> > > > > > Major change: loudnorm no longer returns oversampled audio at
> 192000
> > > Hz
> > > > > > when doing dynamic processing.
> > > > > > Oversampled audio is only used for true peak finding now.
> > > > > > This was trivial improvement as possible with ebur128 code.
> > > > > > Minor changes: numerous stability fixes
> > > > >
> > > > > This patch in unreviewable and should be split.
> > > > >
> > > >
> > > > It cant be split,
> > >
> > > Why not?
> > >
> >
> > Because it is new code and refactoring,
>
> Then it should be first refactoring, then new code.
>

I wrote it wrongly its more than refactoring as code shares no similar code
between this two filters.


>
> > and I know it enough that I'm confident to claim so.
>
> Hubris usually implies more bugs.
>

I tested this a lot, and its great move forward.

Make more useful testing and review next time, I'm sure you are quite
capable person.


>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".