From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7E2E644F4F for ; Wed, 11 Jan 2023 21:06:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9AE1268BD58; Wed, 11 Jan 2023 23:06:29 +0200 (EET) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BDD116807D9 for ; Wed, 11 Jan 2023 23:06:22 +0200 (EET) Received: by mail-vs1-f41.google.com with SMTP id d66so4656159vsd.9 for ; Wed, 11 Jan 2023 13:06:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=y/dbh6aIVMIg4sQ0RZBqiNBzXRbPL2sVq/ju0ggkPiA=; b=I/HbgdRxIcZYjBjnBMRfTNlnLjWD5TBANF1opVX8dGpjapXKgZ4GwNjmZC3KlSvojk g2T7dRXQBR9pw6YxrTtAdlaJvky/oBxML5YijvSKWt9qFSL2iHXrjGqn40jm2VVDf/f+ hPs7VYzxuURnqzOQgLMBIk3bYr25LrHnbYPWhEmHCdZEaCk2VzXJTPo5UdkV1l9ZCG+3 +q8heoD7mhiBLkBSmXZZR786tTKDj8l5SgZh794THE9+h93r7a+TSLrR457aSRRE0Lv+ fiwp4WGbEvRgs6w5ere9u6ueMotXTaVThjcz4Boc+W65VttfH05tSVDo6z9dp3PQgoRX vm8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y/dbh6aIVMIg4sQ0RZBqiNBzXRbPL2sVq/ju0ggkPiA=; b=aH8H+WN3176+iddWjrUmIFWxO9QWnHFDb86Vm44NBzXpUejqANPw3kYuUCy62kuX6B jjY4isxQrDxAZQXBAIVuR7m9JPuTb5SBBfdlS/81tpYKk22hrxSVRMyFW3bKyVlbLp1s zliZWcnna4SMA56gbghlVdITqFTM88Zwa4+nmn58/9T8mbLxAYh1fv/50CUEsBgCtoUl eM9h198/EfhYTI2XTu1F0gKxdCxfC3TGfe7hEaf2NuS0esVE4SbhzauQFAFTp91JI/UB 87B5ACh/a0JtwtOLMq+IIyAUoxYkoPR1elhXmi+NDF/DU01hQSPqX29gEAgQMQIUp72A RW/g== X-Gm-Message-State: AFqh2kpQDuSaSHMNm+kkgaPv0bjsCKCI7XDyYB8krpi5YglKqlQzPPGJ g0bU2IdC10jU+R6wkcVwsD9ftPBXYcbnkeek6vPQ0AZK X-Google-Smtp-Source: AMrXdXuIqHdIS3uJz+WbETr+0UCWUpm3s2HCDXHOsVUAY0HGrjqJjyzTigpT/LgxO00Bxq01Esnl5yB0PJCATKgh3Xw= X-Received: by 2002:a67:ec94:0:b0:3b5:32d0:edcc with SMTP id h20-20020a67ec94000000b003b532d0edccmr10357357vsp.24.1673471180981; Wed, 11 Jan 2023 13:06:20 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Wed, 11 Jan 2023 13:06:19 -0800 (PST) In-Reply-To: <20230111204221.22550-6-michael@niedermayer.cc> References: <20230111204221.22550-1-michael@niedermayer.cc> <20230111204221.22550-6-michael@niedermayer.cc> From: Paul B Mahol Date: Wed, 11 Jan 2023 22:06:19 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 6/6] avcodec/bonk: Check ntaps against buffer size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/11/23, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BONK_fuzzer-6739246658748416 > > Note: This issue was assigned to a unrelated theora bug > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/bonk.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > index 9e176d5477..061cc69a58 100644 > --- a/libavcodec/bonk.c > +++ b/libavcodec/bonk.c > @@ -101,6 +101,10 @@ static av_cold int bonk_init(AVCodecContext *avctx) > s->samples_per_packet = AV_RL16(avctx->extradata + 15); > if (!s->samples_per_packet) > return AVERROR(EINVAL); > + > + if (s->down_sampling * s->samples_per_packet < s->n_taps) > + return AVERROR_INVALIDDATA; > + > s->max_framesize = s->samples_per_packet * avctx->ch_layout.nb_channels > * s->down_sampling * 16LL; > if (s->max_framesize > (INT32_MAX - AV_INPUT_BUFFER_PADDING_SIZE) / 8) > return AVERROR_INVALIDDATA; > -- > 2.17.1 LGTM > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".