Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support
Date: Thu, 21 Mar 2024 21:30:51 +0100
Message-ID: <CAPYw7P5wvgKC9eqn9nJ9EMgd34rU_8ViAQTozDpktWRBHps_qg@mail.gmail.com> (raw)
In-Reply-To: <9D07803F-F9FC-4B97-934B-521E6680F0D4@gmail.com>

On Wed, Mar 20, 2024 at 11:55 PM Yiğithan Yiğit <yigithanyigit35@gmail.com>
wrote:

>
> > On Mar 21, 2024, at 12:10 AM, Paul B Mahol <onemda@gmail.com> wrote:
> >
> > Why? This is pointless.
> >
> > volumedetect have histogram output, float patch does not have it at all.
> > Use astats filter.
> >
> > On Wed, Mar 20, 2024 at 9:47 PM Yiğithan Yiğit <
> yigithanyigit35@gmail.com>
> > wrote:
> >
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel@ffmpeg.org
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >>
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”.
>
> I am a beginner/student also new at open source but I love FFmpeg and
> using in my daily life. From my perspective volumedetect way more user
> friendly. I believe adding this patch would be useful to people such as
> #9613. The reason lack of histogram output for float mostly for my
> indecision about range of the histogram. I am open the suggestions and
> after that I can make a new patch.
>

It is trivial (to some people) to add histogram per dB for float/double
inputs.
But this patch just does some extremely trivial math calculations so that
float input have completely different output from integer ones.
That is very odd and unfriendly from my perspective.

Besides if you only interested in discrete sample audio peak finder in
audio input use astats and measure_overall=Peak_level options.
Yes they are not default on. Because more statistics are more important
than single number.

I'm not against adding proper and useful and correct float/double support
to volumedetect, but it needs to have same/similar structure of output as
integer sample format input audio, otherwise it just looks lazy and prone
for users wondering what is going on when they use different sample formats
in theirs graphs.


>
> Best Regards
> Yigithan
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-03-21 20:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20 20:46 Yiğithan Yiğit
2024-03-20 21:10 ` Paul B Mahol
2024-03-20 22:55   ` Yiğithan Yiğit
2024-03-21 20:30     ` Paul B Mahol [this message]
2024-03-23 14:28       ` Yiğithan Yiğit
2024-03-23 15:21         ` Paul B Mahol
2024-03-23 15:35           ` Yiğithan Yiğit
2024-03-24 21:12             ` Yiğithan Yiğit
2024-03-27 22:39               ` Yiğithan Yiğit
2024-05-01 11:19                 ` Yigithan Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPYw7P5wvgKC9eqn9nJ9EMgd34rU_8ViAQTozDpktWRBHps_qg@mail.gmail.com \
    --to=onemda@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git