From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7CD6C42554 for ; Fri, 18 Mar 2022 14:04:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B6E768B11E; Fri, 18 Mar 2022 16:04:37 +0200 (EET) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB7A168AAD7 for ; Fri, 18 Mar 2022 16:04:30 +0200 (EET) Received: by mail-yb1-f175.google.com with SMTP id t33so8411179ybt.12 for ; Fri, 18 Mar 2022 07:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=vjpFhWJTHCv/s9scjZxt9N0z+b2tQ8wGFrz6V6huIpQ=; b=K7+aSlJgehBpYQRKmDUhlfH+VD4KxdPMDQt5ZROCG7y7SMynw2UNsWDzffeV0hUd7H eI323Xbt2W0yuxgZaqLwmJz69DupYpdjX3c0HZtPBLnF5yd08Yh83UNhu8PeoAmZolxy vIa0YC/qXrrCJO6L/ye0wVF0gfXOh3OempIU71GBreoYnB9nh64BObEUl6Jk1O/jI1Z+ fYsXZjXnDvOqOQYl15Z8P1w6TqS4Mb0K3jrv/CppsrYcl7y9frfreNuNepUJJ+Eols1M sRtZa3rrd1XRF1KRQr825QMR4nt1m1hyoJZvK4TzLYnlAdUgIiJtB2W+MAicmS7D1JFJ dmRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=vjpFhWJTHCv/s9scjZxt9N0z+b2tQ8wGFrz6V6huIpQ=; b=Q3daal82PDhwqYesCmPh4H27D0R7W8w7So8cxCs767qqC4LtpMH+dCzXFSxK6Q3VMb RQzwZSgxWvjRNcl4dEEUUSVRK/uX+bAD4vYRUKIZmG+8XS+z7wHkRc12SFiWvz607GnF C192SiYc2Sq6hH2UfVNklrqIbyT+ZMdAaNUjsVwVQyktmJRMW3fPCw5C4MnxWYY4yhSO tjlqHoYAWh9SnG/5RnJLOJWL/OCyu/LgqM+LgRZUm1xmlcZ4oVXpn8hAus4wb7TxRUGv VnLUkawL2LsgzHjRPo8qvJIlVosAN8Dztsn07XgXr+mD3fdWc6K67huDCta6M+/4cr+U yxBg== X-Gm-Message-State: AOAM530acQCxMKN/75u9s9iKAFTH7lkoPhfvZC0v/rAi3yvz4poigg7M 8QZTzc7vHcgCz46yMkzGHfphitZbHGy2uKDyeuDvkTfK X-Google-Smtp-Source: ABdhPJzVtv/L58eppeIrusppXZbv3R7PSWrQTi04EXUeqSgBupfbO91J1efeasO+LqzVm62ezxyhaP2i3T0U3Z49lgo= X-Received: by 2002:a25:cbd7:0:b0:633:653b:70bc with SMTP id b206-20020a25cbd7000000b00633653b70bcmr10365643ybg.49.1647612269323; Fri, 18 Mar 2022 07:04:29 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:690c:12:0:0:0:0 with HTTP; Fri, 18 Mar 2022 07:04:28 -0700 (PDT) In-Reply-To: References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> <164363001951.23111.4989616914372511566@lain.red.khirnov.net> <14fa7592-4acc-2186-335b-56ea500f9663@mail.de> <2621fec9-555f-c977-b378-dbfd7a6d115e@mail.de> <18f95a99-7efd-1d0c-a824-468ef9b83caa@mail.de> <00b63948-b610-bd38-81fb-95c85235e2f3@mail.de> From: Paul B Mahol Date: Fri, 18 Mar 2022 15:04:28 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/18/22, Thilo Borgmann wrote: > > > On 12 Mar 2022, at 10:06, Thilo Borgmann wrote: > >> Am 09.03.22 um 18:31 schrieb Paul B Mahol: >>> On 3/8/22, Thilo Borgmann wrote: >>>> Am 07.03.22 um 20:06 schrieb Paul B Mahol: >>>>> On 3/7/22, Thilo Borgmann wrote: >>>>>> Am 06.03.22 um 22:25 schrieb Paul B Mahol: >>>>>>> On 3/6/22, Thilo Borgmann wrote: >>>>>>>> Am 22.02.22 um 12:30 schrieb Thilo Borgmann: >>>>>>>>> Am 18.02.22 um 17:08 schrieb Paul B Mahol: >>>>>>>>>> On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann >>>>>>>>>> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Am 31.01.22 um 12:55 schrieb James Almer: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 1/31/2022 8:53 AM, Anton Khirnov wrote: >>>>>>>>>>>>> Quoting Thilo Borgmann (2022-01-18 14:58:07) >>>>>>>>>>>>>>>> Violations of code style. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Enhanced. >>>>>>>>>>>>> >>>>>>>>>>>>> Not enough. There are still many remaining, e.g. >>>>>>>>>>>>> * opening brace of a function definition should be on its own >>>>>>>>>>>>> line >>>>>>>>>>>>> * the context should generally be the first argument >>>>>>>>>>>>> * unsigned char* should be uint8_t* >>>>>>>>>>>>> * mixed declarations and code (the compiler should warn about >>>>>>>>>>>>> that) >>>>>>>>>>>> >>>>>>>>>>>> I think someone said that clang (or some versions) is >>>>>>>>>>>> apparently >>>>>>>>>>>> not >>>>>>>>>>> warning about this, hence why so many of these end up being >>>>>>>>>>> missed >>>>>>>>>>> in >>>>>>>>>>> reviews or even by the patch author. >>>>>>>>>>> >>>>>>>>>>> This and all of Anton's comments in v3. Also removed some more >>>>>>>>>>> obviously >>>>>>>>>>> useless doubles. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Why it uses doubles in so many places? >>>>>>>>>> Is there any real benefit in that, except extra slowdown? >>>>>>>>> >>>>>>>>> I guess because it's originating in some c&p Matlab code. >>>>>>>>> I did %s#double#float#g for v4, loosing some precision we can >>>>>>>>> ignore >>>>>>>>> IMHO. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> v3: >>>>>>>>> >>>>>>>>> Total frames: 2 >>>>>>>>> >>>>>>>>> Spatial Information: >>>>>>>>> Average: 165.451985 >>>>>>>>> Max: 165.817542 >>>>>>>>> Min: 165.086427 >>>>>>>>> >>>>>>>>> Temporal Information: >>>>>>>>> Average: 1.007263 >>>>>>>>> Max: 2.014525 >>>>>>>>> Min: 0.000000 >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> v4: >>>>>>>>> >>>>>>>>> Total frames: 2 >>>>>>>>> >>>>>>>>> Spatial Information: >>>>>>>>> Average: 164.385895 >>>>>>>>> Max: 164.742325 >>>>>>>>> Min: 164.029480 >>>>>>>>> >>>>>>>>> Temporal Information: >>>>>>>>> Average: 1.007241 >>>>>>>>> Max: 2.014483 >>>>>>>>> Min: 0.000000 >>>>>>>>> >>>>>>>> >>>>>>>> Ping. >>>>>>> >>>>>>> Into wrong section of changelog added entry. >>>>>>> >>>>>>> Useless cast of allocation results. >>>>>>> >>>>>>> Does filter changes pixels? If not, add metadata flag to appropriate >>>>>>> place. >>>>>> >>>>>> All addressed in v5, thx! >>>>>> >>>>> >>>>> Changelog entry is still in wrong, 5.0, section. >>>> >>>> Fixed in v6. >>>> >>>>>> Also added a FATE test for it. >>>> >>>> >>> >>> Could use fminf/ float functions instead of double variants. >> >> v7. > > Going to push soon if there are no more comments. Check that returned values are correct for bigger w/h, and that not values reach too high values for floats which may cause loss of precision in best case, eg. maybe you need to normalize pixel values from 0-255 to 0.f-1.f so mean/stddev does not get bad results. > > -Thilo > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".