From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A270446577 for ; Sun, 21 May 2023 21:05:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 54B8D68C007; Mon, 22 May 2023 00:05:31 +0300 (EEST) Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7AA14687F3A for ; Mon, 22 May 2023 00:05:24 +0300 (EEST) Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-456d241fcdcso1401222e0c.0 for ; Sun, 21 May 2023 14:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684703123; x=1687295123; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ZxHi4nmhvr1rLXK94pNrl74nqifLdWJOQTG6UoK29aA=; b=a0hG67cEX2XHrAvFSpzN/O3/2IBoiSNvbeOUkb2cIToJUah+a7vilFu5B4UTWUpAkA +7H9QRB8XlMskFyOIOaF0hJc7NLu5/gQuev2GeOu0HzU1gBo4O7wayp2uL5o8nwUmXan XzC/mlcVA+EyJ18iNatYaGY8iYUQeoR/NeVO8oS0ci5V7yfluE1g043wQ8jYZqyPVRex vyBdAXamxwKARFI+2g0BQEvtjdjjM4iHE9XQlhvYPEYoBBvQ92i61AyQGbjS01KnjlBc V+gqY1rvF+pIwf4Yh1vjfJH9abx9YkV3K9M5P4nnXLAI5SyPO0r+yyNM02m0rvydKhkG KPhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684703123; x=1687295123; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZxHi4nmhvr1rLXK94pNrl74nqifLdWJOQTG6UoK29aA=; b=GF7TQcNGTpcpy5LI0EqMrpR+/vupF2nrVwSm47fXIsGxfWtqwPydIHkJsO/EZhAuKk UrEBgzZzHFIB9eLJ40gJedwt4yI9nItQIRPiFgatAcQyAM137sD2G3eH0zLXi/OjzvEU wKHnnz4+v3X+MHjWoaVEYTCNIHQn3XfsggG7VCUjuQa4NyLZPbtMBoCj8rGJwtbQ6DOt ZC4pwh4l4JfDsKlf+AhddetrZJQkle721DI9v2EK37RaMmkwb2FHcnnLyNgPqgxiiybM lUNq6vW1FcidVxRBRqztPqowy6ZzyQqTT5jGm/jGyiZu6PaB4kjCP6i3lTvoj6bexUzb 9SXg== X-Gm-Message-State: AC+VfDyLIHcSEVdEWUTRGdRhUk/+YsOiVq5xVM0Sqf3VLKannqLQfLhI 5bJBNjQDWi7VtScJOX6J9e/QUCGCviTZ82KcKDnsNmvx X-Google-Smtp-Source: ACHHUZ4rp/Draj1ou48owmUhgEWnF3eAixFogRlSDRRCUF1cRZCz3HnhvoeXgdTNgTTEzVedXklnm92cTOIz5YbBiw8= X-Received: by 2002:a67:bb09:0:b0:421:c588:4d40 with SMTP id m9-20020a67bb09000000b00421c5884d40mr1894951vsn.15.1684703122813; Sun, 21 May 2023 14:05:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a59:cd03:0:b0:3b6:f9a0:5488 with HTTP; Sun, 21 May 2023 14:05:21 -0700 (PDT) In-Reply-To: <20230521204700.GJ1391451@pb2> References: <20230305114346.19875-1-michael@niedermayer.cc> <20230305190220.GC1928637@pb2> <20230521204700.GJ1391451@pb2> From: Paul B Mahol Date: Sun, 21 May 2023 23:05:21 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/21/23, Michael Niedermayer wrote: > On Sun, Mar 05, 2023 at 08:02:20PM +0100, Michael Niedermayer wrote: >> On Sun, Mar 05, 2023 at 05:37:09PM +0100, Paul B Mahol wrote: >> > On 3/5/23, Michael Niedermayer wrote: >> > > Fixes: left shift of 538976288 by 13 places cannot be represented in >> > > type >> > > 'int' >> > > Fixes: >> > > 56148/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-6257370708967424 >> > > >> > >> > Please make sure that this does not break decoding. >> >> how ? >> >> * Testing all rka files on the internet ? >> i cannot >> >> * Reading the specification ? >> i failed to find a public specification >> >> * Generating files that have a high enough sample rate with the binary >> windows >> encoder? >> "ERROR: Unsupported format type." even at 88.2k, well below that point >> >> Also if it worked before its dependant on the compiler, its undefined >> bahevior. >> For files with more normal sample rates like the sample in our archieve >> it produces the same output. >> >> Other ideas ? > > is above ok or should more testing be done ? whatever. > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > it is not once nor twice but times without number that the same ideas make > their appearance in the world. -- Aristotle > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".