From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation
Date: Sun, 21 May 2023 23:05:21 +0200
Message-ID: <CAPYw7P5tH+pmt=hiLjbpEg8V2gj71SMdU5FLhGd5QhTdoihczw@mail.gmail.com> (raw)
In-Reply-To: <20230521204700.GJ1391451@pb2>
On 5/21/23, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Sun, Mar 05, 2023 at 08:02:20PM +0100, Michael Niedermayer wrote:
>> On Sun, Mar 05, 2023 at 05:37:09PM +0100, Paul B Mahol wrote:
>> > On 3/5/23, Michael Niedermayer <michael@niedermayer.cc> wrote:
>> > > Fixes: left shift of 538976288 by 13 places cannot be represented in
>> > > type
>> > > 'int'
>> > > Fixes:
>> > > 56148/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-6257370708967424
>> > >
>> >
>> > Please make sure that this does not break decoding.
>>
>> how ?
>>
>> * Testing all rka files on the internet ?
>> i cannot
>>
>> * Reading the specification ?
>> i failed to find a public specification
>>
>> * Generating files that have a high enough sample rate with the binary
>> windows
>> encoder?
>> "ERROR: Unsupported format type." even at 88.2k, well below that point
>>
>> Also if it worked before its dependant on the compiler, its undefined
>> bahevior.
>> For files with more normal sample rates like the sample in our archieve
>> it produces the same output.
>>
>> Other ideas ?
>
> is above ok or should more testing be done ?
whatever.
> thx
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> it is not once nor twice but times without number that the same ideas make
> their appearance in the world. -- Aristotle
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-21 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 11:43 Michael Niedermayer
2023-03-05 11:43 ` [FFmpeg-devel] [PATCH 2/2] avformat/wavdec: Check that smv block fits in available space Michael Niedermayer
2023-05-21 20:44 ` Michael Niedermayer
2023-03-05 16:37 ` [FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation Paul B Mahol
2023-03-05 19:02 ` Michael Niedermayer
2023-05-21 20:47 ` Michael Niedermayer
2023-05-21 21:05 ` Paul B Mahol [this message]
2023-06-03 18:52 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P5tH+pmt=hiLjbpEg8V2gj71SMdU5FLhGd5QhTdoihczw@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git