From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EFC4140C83 for ; Wed, 9 Mar 2022 17:31:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0B6E668AFB3; Wed, 9 Mar 2022 19:31:37 +0200 (EET) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6BCAC680068 for ; Wed, 9 Mar 2022 19:31:30 +0200 (EET) Received: by mail-yb1-f169.google.com with SMTP id z30so5907330ybi.2 for ; Wed, 09 Mar 2022 09:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=iDQhgRnDCom/z93UR5dvN6ODvJ7cx45CLT69r+xKxo0=; b=eR6/2+Vt+wtB6zV5Rl2ezlhfy4oCNy/wadadwUmKzGomyyanQR/G7/LvydphG4CHRk eB9zthKDnsyDNJ91HbwbnDFpKfRgDI0ulB9jQmAyrtI2HIOzWlGdiNN38cyaMJdZfOVD HIedeOsgX/lS96Me5Y6ZlQygTvdl2v4fiECBieTgG8nYDROWWL5xrjVOJ7qlQgywSw/7 QRWC4lN1SANBFd96tyeeMOtHx5oZRyI1VlR9WWc+tXTeRb+Q0ujWRukvFHBS8Opa4ESi y6wcIsrpXI8u7+hAjHn50mHzv+rFfe9dHlxPQhjeM+F9wi2EfnT5tEjd6Tmz8FUSBWOG eM5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=iDQhgRnDCom/z93UR5dvN6ODvJ7cx45CLT69r+xKxo0=; b=FspQ6N7WgyQIS0RaLqAT3aLJ9y2C2YdByQQD9vDt7EQAq1JIGEOnbQQo+HMmJ7mlNu /Iy4Q9J1FmiNqnnQ/uhIAFUeh1J/QLLeIwwFVRrO3tg+Ay6xwULw+slSv+T1/rsSPgdI nGyRVSGrxOc9EXhYNKLUoJZzQG9/wfROswkIuQhEuG85UFVtuWvl6INl6xk2CZAzWeQm 6YwZ2F9QjFBtaOBUTw5I8XEdxl9Dp99hujKU+W/16qBPq87HOSYGFihtHJg4e/2W9Vuz ar9PM70YcYEg5OElVGby3xsTyJWyWYvbcaBm7sT2EwOynA77MyczX07QCApGd8F6bnYw IVyA== X-Gm-Message-State: AOAM530ZNfJga4NjLW7XF8zt/Gv7mxAK7UErk3FrKhH87qOLlNVuk8lt olrQg4697U1wd53gvVkCeXJac0R54VrrElGHqvnKUodu X-Google-Smtp-Source: ABdhPJyCoR9IcIk7myNNOgfkBg9bIza7l+FPQP3/ipHnNmWlc7NlWNBcA6mcfF1j8/w1SZvv+sS4H2tlqH82aG4Xu6Q= X-Received: by 2002:a25:8d8f:0:b0:628:c2e3:18fd with SMTP id o15-20020a258d8f000000b00628c2e318fdmr710584ybl.396.1646847088630; Wed, 09 Mar 2022 09:31:28 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:690c:12:0:0:0:0 with HTTP; Wed, 9 Mar 2022 09:31:27 -0800 (PST) In-Reply-To: <18f95a99-7efd-1d0c-a824-468ef9b83caa@mail.de> References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> <164363001951.23111.4989616914372511566@lain.red.khirnov.net> <14fa7592-4acc-2186-335b-56ea500f9663@mail.de> <2621fec9-555f-c977-b378-dbfd7a6d115e@mail.de> <18f95a99-7efd-1d0c-a824-468ef9b83caa@mail.de> From: Paul B Mahol Date: Wed, 9 Mar 2022 18:31:27 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/8/22, Thilo Borgmann wrote: > Am 07.03.22 um 20:06 schrieb Paul B Mahol: >> On 3/7/22, Thilo Borgmann wrote: >>> Am 06.03.22 um 22:25 schrieb Paul B Mahol: >>>> On 3/6/22, Thilo Borgmann wrote: >>>>> Am 22.02.22 um 12:30 schrieb Thilo Borgmann: >>>>>> Am 18.02.22 um 17:08 schrieb Paul B Mahol: >>>>>>> On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann >>>>>>> >>>>>>> wrote: >>>>>>> >>>>>>>> Am 31.01.22 um 12:55 schrieb James Almer: >>>>>>>>> >>>>>>>>> >>>>>>>>> On 1/31/2022 8:53 AM, Anton Khirnov wrote: >>>>>>>>>> Quoting Thilo Borgmann (2022-01-18 14:58:07) >>>>>>>>>>>>> Violations of code style. >>>>>>>>>>> >>>>>>>>>>> Enhanced. >>>>>>>>>> >>>>>>>>>> Not enough. There are still many remaining, e.g. >>>>>>>>>> * opening brace of a function definition should be on its own >>>>>>>>>> line >>>>>>>>>> * the context should generally be the first argument >>>>>>>>>> * unsigned char* should be uint8_t* >>>>>>>>>> * mixed declarations and code (the compiler should warn about >>>>>>>>>> that) >>>>>>>>> >>>>>>>>> I think someone said that clang (or some versions) is apparently >>>>>>>>> not >>>>>>>> warning about this, hence why so many of these end up being missed >>>>>>>> in >>>>>>>> reviews or even by the patch author. >>>>>>>> >>>>>>>> This and all of Anton's comments in v3. Also removed some more >>>>>>>> obviously >>>>>>>> useless doubles. >>>>>>>> >>>>>>> >>>>>>> Why it uses doubles in so many places? >>>>>>> Is there any real benefit in that, except extra slowdown? >>>>>> >>>>>> I guess because it's originating in some c&p Matlab code. >>>>>> I did %s#double#float#g for v4, loosing some precision we can ignore >>>>>> IMHO. >>>>>> >>>>>> >>>>>> >>>>>> v3: >>>>>> >>>>>> Total frames: 2 >>>>>> >>>>>> Spatial Information: >>>>>> Average: 165.451985 >>>>>> Max: 165.817542 >>>>>> Min: 165.086427 >>>>>> >>>>>> Temporal Information: >>>>>> Average: 1.007263 >>>>>> Max: 2.014525 >>>>>> Min: 0.000000 >>>>>> >>>>>> >>>>>> >>>>>> v4: >>>>>> >>>>>> Total frames: 2 >>>>>> >>>>>> Spatial Information: >>>>>> Average: 164.385895 >>>>>> Max: 164.742325 >>>>>> Min: 164.029480 >>>>>> >>>>>> Temporal Information: >>>>>> Average: 1.007241 >>>>>> Max: 2.014483 >>>>>> Min: 0.000000 >>>>>> >>>>> >>>>> Ping. >>>> >>>> Into wrong section of changelog added entry. >>>> >>>> Useless cast of allocation results. >>>> >>>> Does filter changes pixels? If not, add metadata flag to appropriate >>>> place. >>> >>> All addressed in v5, thx! >>> >> >> Changelog entry is still in wrong, 5.0, section. > > Fixed in v6. > >>> Also added a FATE test for it. > > Could use fminf/ float functions instead of double variants. > -Thilo > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".