From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 43D3F43E59 for ; Thu, 15 Sep 2022 16:01:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C5D9968BBB7; Thu, 15 Sep 2022 19:01:10 +0300 (EEST) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 161A568BB3E for ; Thu, 15 Sep 2022 19:01:04 +0300 (EEST) Received: by mail-yb1-f179.google.com with SMTP id c9so28355031ybf.5 for ; Thu, 15 Sep 2022 09:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date; bh=iF+7+YVAvpdh9OMuP4SCuY953tDQ38RZYPdruY8EGLU=; b=kMeRMKdr/F2xQYU9xKZhRp7BVgoPJm548SNNGD0j7B1pQ0aZ1rkBNRAxevRr74hVKu esXGAOmlbfwf2tB8VUvqnn9AYUYQ9btXQinv/ghVtlq8aYhmu78+x7E2LrLZgpW3IMvP OvA5MDvkka0Sp0iT4vWd54JP+WD0wTkX8oh7ZUnyAn/FoaSMnW0nBGbmL6CTQphBXbJ+ zMdJaOJK/tzIqp1875CwtELf3egTTlgbNr4OBG98UqHQ2n015bPEp9c+c0wo6Aq7acB9 SXm6SWYWYjyw4M4NQuzzaYuzc2hLDVSErJddfOYnI261i38+Awu2hgD2ePSsr6jEp6rv uYcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=iF+7+YVAvpdh9OMuP4SCuY953tDQ38RZYPdruY8EGLU=; b=PqhvHUdsJkL3c5wgMbIMG7M7KGuD1DlQyG1aD9vVd5DnKIWzr0FTyWYamCviygEFU3 VDmV0CIqB2Upfezo/4kEM9q8OP5xVhrCjQ4l+x6jCrthpEf5ydQk+GTDTg9Cr3kiYdLv mfpw3/zxpGCr92OZqLWyYhEU5JpDyFLDymcF85cdbbwXhaTR+URF6dc3r40kXuT+O44E jZUriK9t/fY6CTXlBLQPPvr5X0cXIxxc838yYjU9mvdKrsbSYdj/NeSguNVjuT3OH9zL soD4FP16ou33L1pfIrWJztwZvSpqeindWoDd/gysPR/2RV6hzIoL61jiYY29ge682HF7 sXGQ== X-Gm-Message-State: ACrzQf1g4sd/1P3TGSZEPwlA9ASKsClBJB5wTQdcLSMUmbjA14aIUw1Z oDGGkK6U3fmeNjOJ8UD5RkHRowaax9MugJ+JgCCOKZvL X-Google-Smtp-Source: AMsMyM6AtyBXRDQXexm9geQ1F86CxILlbNmqd0je+jzdVumw84tzaWtHZdW00ZeeQxODnDyPKOq8zcAxMc1qMKOk1HQ= X-Received: by 2002:a5b:485:0:b0:67c:2c89:f3a3 with SMTP id n5-20020a5b0485000000b0067c2c89f3a3mr363272ybp.571.1663257662222; Thu, 15 Sep 2022 09:01:02 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:7402:0:0:0:0:0 with HTTP; Thu, 15 Sep 2022 09:01:01 -0700 (PDT) In-Reply-To: References: From: Paul B Mahol Date: Thu, 15 Sep 2022 18:01:01 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/adpcmenc: Round up required buffer size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/15/22, Andreas Rheinhardt wrote: > Otherwise the buffer might be too small. Fixes assert violations > when encoding mono audio with exactly one sample. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/adpcmenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c > index 1ffc5b410f..57709b19a1 100644 > --- a/libavcodec/adpcmenc.c > +++ b/libavcodec/adpcmenc.c > @@ -614,7 +614,7 @@ static int adpcm_encode_frame(AVCodecContext *avctx, > AVPacket *avpkt, > avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_ALP || > avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_APM || > avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_WS) > - pkt_size = (frame->nb_samples * channels) / 2; > + pkt_size = (frame->nb_samples * channels + 1) / 2; > else > pkt_size = avctx->block_align; > if ((ret = ff_get_encode_buffer(avctx, avpkt, pkt_size, 0)) < 0) > -- > 2.34.1 Nice catch, LGTM. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".