From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A4F1444F14 for ; Mon, 9 Jan 2023 12:25:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 69C1C68BCBC; Mon, 9 Jan 2023 14:25:19 +0200 (EET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F0E0C68BC1B for ; Mon, 9 Jan 2023 14:25:12 +0200 (EET) Received: by mail-vs1-f47.google.com with SMTP id n190so4492635vsc.11 for ; Mon, 09 Jan 2023 04:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=0bSnzvlB3xO6Ho3ZRm0G0K/MDb2zwrOU0BhJCCla91M=; b=ousH/Ta7rqe9u1izjm0gKCAOgb35bmM1wp6u3XPnbn/mfUoUjhZ1YQ42KsiOWk05Is zIDnoVQDoRNkPe6i2R9jDDsFq2QMlC80LqJIpG8fLFxL1O8SLQ29/TuYwX137MF8RLgK qGew5EIEcZtOZ+yR/vBLtjzcXOif14o9T/pRqXRmITwuugBKinsfBQRT/weLx+2NFFDN pf+2Uw+npbVaVHgA0G6yxnG8rHIBx4fDqIXxGH1OLvhv6UHppqv5kM0xjl/51Aedqs7W 0d98ik0jETgA3/GoHHGw4B1cKqk8qlrzazF5maxU/y2nrDmTzqtLaXsEWOMgOM08OTKq 3TvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0bSnzvlB3xO6Ho3ZRm0G0K/MDb2zwrOU0BhJCCla91M=; b=l2eeOQ2JhQ6wugmoOmGGyGgVAx2LYabeFNPctoDL66PSVxcKmJhJyOAxb9LCgmq3yX u0a1xlylhz6KbBbTx9wr4Z7kn/Usx7h1sfj5c429ZkcCD/P++ceIdPkSv/VL23yVw43E VuEkdocEJj+8fzhYOoLfVRsvobfuZWh2aFn8Wush0/XWIY9ZrOt/lboeKPibUeEsRKIA K9mN9n3U4Yqw1VEp3FsAY4YnoFiM4Y2oP3AI8hWjNshJzT8iwRdrdx1ovWs+gk1EvwG+ 0XLiokp8HjeG9I7PI7luvIQQ01OzR5CjA07ZT6Q2Yu7+5ScQscp1LS+BobhU/QJBZg9k iIlA== X-Gm-Message-State: AFqh2krFetPU4MArptmCtVAKw2joM2+3w6EcEuIcpozOqiE9JZtlBAaM H2NtaFbAynJr+m4xYG3zPcHrstkKNXfqVE8uXqezBIAN X-Google-Smtp-Source: AMrXdXsYIjEY6V46UmUZzji9caN/xw2wxSPKzEd+70riD+8+dNv80gS4WvXopXwp1qZPiaMCMM3JfVR7GXPJvl3He40= X-Received: by 2002:a67:d019:0:b0:3d0:b6fd:9609 with SMTP id r25-20020a67d019000000b003d0b6fd9609mr145880vsi.15.1673267111151; Mon, 09 Jan 2023 04:25:11 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Mon, 9 Jan 2023 04:25:09 -0800 (PST) In-Reply-To: References: <20230105205342.GE4028235@pb2> <20230106172506.GG4028235@pb2> <20230108144532.GC35806@pb2> From: Paul B Mahol Date: Mon, 9 Jan 2023 13:25:09 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/9/23, Tobias Rapp wrote: > On 08/01/2023 15:45, Michael Niedermayer wrote: > >> On Fri, Jan 06, 2023 at 07:01:06PM +0100, Paul B Mahol wrote: >>> On Fri, Jan 6, 2023 at 6:25 PM Michael Niedermayer >>> >>> wrote: >>> >>>> On Thu, Jan 05, 2023 at 11:08:25PM +0100, Paul B Mahol wrote: >>>>> On Thu, Jan 5, 2023 at 9:53 PM Michael Niedermayer < >>>> michael@niedermayer.cc> >>>>> wrote: >>>>> >>>>>> On Thu, Jan 05, 2023 at 01:44:10PM +0100, Paul B Mahol wrote: >>>>>>> Patch attached. >>>>>>> swresample.c | 3 ++- >>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>>> eee7a0685b44aa867562138a2e2437ecb8844612 >>>>>> 0001-libswresample-swresample-avoid-s16p-internal-transfe.patch >>>>>>> From 9c4cd60e2dd41cf98d693c8251f4cfade0807073 Mon Sep 17 00:00:00 >>>> 2001 >>>>>>> From: Paul B Mahol >>>>>>> Date: Thu, 5 Jan 2023 13:40:12 +0100 >>>>>>> Subject: [PATCH] libswresample/swresample: avoid s16p internal >>>> transfer >>>>>> format >>>>>>> Instead use float one by default for sample rate conversions. >>>>>>> The s16p internal transfer format produces visible and hearable >>>>>>> quantization artifacts. >>>>>> When does this occur and why? >>>>>> >>>>> It occurs always. Just compare output with 16bit and >>>>> int32/float/double. >>>>> Look at other people report on internet. >>>>> Look at src.infinitewave.ca >>>> src.infinitewave.ca uses 32bit none of what it shows should touch the >>>> codepath >>>> you change. >>>> >>>> if we look at src.infinitewave.ca for swr we see 2 types of artifacts >>>> 1. Aliassing which is at maybe -120db with the actual signal at 0db >>>> i would like to see some evidence that a human can hear this >>>> >>> For s16p<->s16p it is much lower, around -78dB thus this patch. >> ok but you pointed to the website that apparently uses >=32bit if i trust >> what they write. >> And even if they test this i cannot use that website to replicate the >> issue >> and the fix >> >> I just wanted to know how i can test this. You are testing it too ... >> so i can see what you see >> Id like to make sure this is the correct fix for the problem and >> Id like to make sure its used when it makes sense and not when not. > > IIRC a similar sweep graph can be created with "Spek" from > http://spek.cc/ but haven't used that application for a while. The SRC Spek is both slow and limited in range of dB, so it should never be used by pro users. > comparison website apparently provides the input files for testing, see > the instructions at http://src.infinitewave.ca/faq.html. > > Regards, Tobias > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".