From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E582F42301 for ; Mon, 4 Apr 2022 15:47:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3DB0D68B2EC; Mon, 4 Apr 2022 18:47:43 +0300 (EEST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 175C168A3AD for ; Mon, 4 Apr 2022 18:47:36 +0300 (EEST) Received: by mail-yb1-f174.google.com with SMTP id d138so9987030ybc.13 for ; Mon, 04 Apr 2022 08:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=tivBOSVQVElpcF1q8/0GCTN9yyAr099s7rxNRVan5j4=; b=CO7MiMwys6m8SRv/azmIX5YEmEllBMqT58xHj7/QAoJKRnUNjTFvKbOh1bVkhmGXhA ZBQ32Kfl/+EFTuSK0ykgtAFkKvHkKNAC01EpJakx+YV/F4ISpMHvDBT0nwmZy3LYH5wf XxfrWh09WUPxyTrNg7JglWYhNiy7CeLErPPwW/anRyaQY25Zc3EOfEpzrxu+hTQaKny1 UNoTb/FZjQKbZjHXHOK9LZvCO+AuH6v+4iShNMRkRdnGRr1FGwtB2EQJ1lszfOOB0/5a Ts9jh+hxjowMp9nLs90KXyINhHIeyVAColQQ++OvpCrNchhCTnfvR5v+SdxHpV5dFi8R UDDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=tivBOSVQVElpcF1q8/0GCTN9yyAr099s7rxNRVan5j4=; b=S5uz90AjSRRNlO9YuWBHH1D2ebRiuisUjSPNOQqcYGR1iR8/+ck4aa00+qxNKnPcTv Ntbpax6MS+YWql8zBB0ukFQQ33P0GcPqWGkt07JDQqBYPaHvxkVtKLVo5ULbjlc80Tpr LVH/VR0QJz/he5YYFzM0lu8+hZ7aEzObT+13Gaftt6i7DptFvRIEc8CJyDe4YCTcAgM5 g1VnkXfjJ4gjlGA/D+NdD3TLHcA2FAmZrfbRD9ze6pmuoA6SU7gWTjcdAhOz9JAveKnZ MvorQQzBFcKvXyeAK8+G+U+MLkc6zdoK3XFZ/1N7H+QXBg1H+Kqo0acEc+bqEZSRDL6g P1EA== X-Gm-Message-State: AOAM533Q7TzJkQbtA35kEu54eINzbjH8bZ9l3RNt5ExumPmMmXIQgP/J iq0L2odKVA7UyyPNtbijJP1Hb4qlZj8/eAFq2CSyujQ5 X-Google-Smtp-Source: ABdhPJxlonGjnbh7sdEKhV0vfpMKXoUmgvziw9+6W4z5QLY/DLIiG9x7+ZORRKYawxQ2CoBi7Um/j/JPXeuF0uksnsA= X-Received: by 2002:a5b:8cc:0:b0:634:7343:9953 with SMTP id w12-20020a5b08cc000000b0063473439953mr427364ybq.142.1649087254587; Mon, 04 Apr 2022 08:47:34 -0700 (PDT) MIME-Version: 1.0 References: <20220327060800.3732289-1-wangcao@google.com> <2ec3971d-f698-1369-1ace-eac613afc980@passwd.hu> In-Reply-To: <2ec3971d-f698-1369-1ace-eac613afc980@passwd.hu> From: Paul B Mahol Date: Mon, 4 Apr 2022 17:49:46 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/alimiter: Add "flush_buffer" option to flush the remaining valid data to the output X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, Mar 27, 2022 at 11:41 PM Marton Balint wrote: > > > On Sat, 26 Mar 2022, Wang Cao wrote: > > > The change in the commit will add some samples to the end of the audio > > stream. The intention is to add a "zero_delay" option eventually to not > > have the delay in the begining the output from alimiter due to > > lookahead. > > I was very much suprised to see that the alimiter filter actually delays > the audio - as in extra samples are inserted in the beginning and some > samples are cut in the end. This trashes A-V sync, so it is a bug IMHO. > > So unless somebody has some valid usecase for the legacy way of operation > I'd just simply change it to be "zero delay" without any additional user > option, in a single patch. > This is done by this patch in very complicated way and also it really should be optional. Something like in af_ladspa is more reasonable. > > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".