Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: switch to activate

[Paul B Mahol <onemda@gmail.com>]

On Sat, May 27, 2023 at 5:46 PM Paul B Mahol <onemda@gmail.com> wrote:

>
>
> On Sat, May 27, 2023 at 5:43 PM Anton Khirnov <anton@khirnov.net> wrote:
>
>> Quoting Paul B Mahol (2023-05-18 19:48:47)
>> > Attached.
>> >
>> > From c06d3d9f6020fdda19641637cafa6f86c77b4b73 Mon Sep 17 00:00:00 2001
>> > From: Paul B Mahol <onemda@gmail.com>
>> > Date: Wed, 17 May 2023 09:14:56 +0200
>> > Subject: [PATCH 21/27] avfilter/af_apad: switch to activate
>> >
>> > Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> > ---
>> >  libavfilter/af_apad.c | 105 ++++++++++++++++++++++++++++--------------
>> >  1 file changed, 71 insertions(+), 34 deletions(-)
>>
>> The commit message for such commits should mention why is this better,
>> because it is not obvious. For one thing, the new code is significantly
>> longer.
>>
>

Than I will count your net change in lines too, and will reject such
patches from 0.
~30 lines is irrelevant. This fixes EOF reporting which when combined with
other filters in filter graph can reduce usage of both processing and
memory resources significantly.

I'm astonished of your lack of general knowledge in this domain.



>
>
>>
>> --
>> Anton Khirnov
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".