Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: reduce default max reload to 100

[Paul B Mahol <onemda@gmail.com>]

On Wed, May 10, 2023 at 11:58 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> The 1000 did result in a apparent never ending reload loop
>
>
How so? Somewhere overflow happens causing infinity?



> Issue found by: Сергей Колесников
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/hls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 11e345b280..77bce8fc0d 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -2556,7 +2556,7 @@ static const AVOption hls_options[] = {
>          {.str =
> "3gp,aac,avi,ac3,eac3,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"},
>          INT_MIN, INT_MAX, FLAGS},
>      {"max_reload", "Maximum number of times a insufficient list is
> attempted to be reloaded",
> -        OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX,
> FLAGS},
> +        OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 100}, 0, INT_MAX,
> FLAGS},
>      {"m3u8_hold_counters", "The maximum number of times to load m3u8 when
> it refreshes without new segments",
>          OFFSET(m3u8_hold_counters), AV_OPT_TYPE_INT, {.i64 = 1000}, 0,
> INT_MAX, FLAGS},
>      {"http_persistent", "Use persistent HTTP connections",
> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".