From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Add SMC vsynth tests
Date: Sun, 2 Jul 2023 20:57:26 +0200
Message-ID: <CAPYw7P5VOZod26cNVx8Q5M+utBmLg=KgEkQvJJE2UWfajGz93A@mail.gmail.com> (raw)
In-Reply-To: <0aa39ebb82a58cfd61df43d192d06f59f4e2a46b.camel@haerdin.se>
On Sun, Jul 2, 2023 at 6:39 PM Tomas Härdin <git@haerdin.se> wrote:
> sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin:
> > sön 2023-07-02 klockan 12:49 -0300 skrev James Almer:
> > > On 7/2/2023 12:28 PM, Tomas Härdin wrote:
> > > >
> > > > ---
> > > > tests/fate/vcodec.mak | 3 +++
> > > > tests/ref/vsynth/vsynth1-smc | 4 ++++
> > > > tests/ref/vsynth/vsynth2-smc | 4 ++++
> > > > tests/ref/vsynth/vsynth3-smc | 4 ++++
> > > > tests/ref/vsynth/vsynth_lena-smc | 4 ++++
> > > > 5 files changed, 19 insertions(+)
> > > > create mode 100644 tests/ref/vsynth/vsynth1-smc
> > > > create mode 100644 tests/ref/vsynth/vsynth2-smc
> > > > create mode 100644 tests/ref/vsynth/vsynth3-smc
> > > > create mode 100644 tests/ref/vsynth/vsynth_lena-smc
> > > >
> > > > diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> > > > index ef8904613a..833dde86ab 100644
> > > > --- a/tests/fate/vcodec.mak
> > > > +++ b/tests/fate/vcodec.mak
> > > > @@ -404,6 +404,9 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM) +=
> > > > rv20
> > > > fate-vsynth%-rv20: ENCOPTS = -qscale 10
> > > > fate-vsynth%-rv20: FMT = rm
> > > >
> > > > +FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
> > > > +fate-vsynth%-smc: CODEC = smc
> > >
> > > Missing a FMT = mp4 line (or mov if smc is supported in it).
> >
> > It already says MOV in the call, and mp4 doesn't support SMC
>
> Oh wait the MOV is just for deps I guess, not the actual format output.
> Updated patch attached
>
LGTM
Feel free to push if it passes tests.
>
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-02 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 15:28 Tomas Härdin
2023-07-02 15:49 ` James Almer
2023-07-02 16:36 ` Tomas Härdin
2023-07-02 16:39 ` Tomas Härdin
2023-07-02 18:57 ` Paul B Mahol [this message]
2023-07-02 19:17 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P5VOZod26cNVx8Q5M+utBmLg=KgEkQvJJE2UWfajGz93A@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git