From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AFF4C43D06 for ; Wed, 7 Sep 2022 10:48:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5015C68BB83; Wed, 7 Sep 2022 13:48:25 +0300 (EEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 22D3668BB29 for ; Wed, 7 Sep 2022 13:48:19 +0300 (EEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-3378303138bso122615047b3.9 for ; Wed, 07 Sep 2022 03:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=XmG6RI7crx/IR9Vwiw671eMC6qkkWA57RKEGp/JvxE8=; b=YOXwtNqOostd1/U9e5c7xAgs8ctE5/Nz/jdZNajPICUu4+UqUq9A+zFOVUf1SF/vYD IL6490U5pZfhvtKN8QwML+uVB2hBq1T4coq5lUN29zvP4RD5E8WfnnO+gqhfocVWyVQJ iV2Ht3UwS+GMmtJHuHwkH+M2LexJ6DNIk7biZJ2eaVGxi0+kkaPF2nKFCDLWxZxYAcNI vZCs7KYrEqQhV6wC4cSK9FVyHeWsqqlxtQ5X6DUy3+RiOPQpRZ2BfOcNXtQhFkDwZwu3 TdPWEL2Z9NUnjUDQOsUGoMji0RHcF3Kf4MTtX8V2dwFAk2JC0+4EEC/pe0LPxVAOG/QN u1Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=XmG6RI7crx/IR9Vwiw671eMC6qkkWA57RKEGp/JvxE8=; b=Iz30FbDdXQnk0yVOnwTt0BOBd3NhWZU2z36bXTq2KUEfzPniPcyX2fdWFtNrRsCHGm wtiFFHY6dzpm7URMaRObKIMiTx0SDsOMCwkCSRGbirbUDsvP/7JxAM5L9xQTOmGQx/B6 f7krsmW6/P7JrYqp+bMf+BSVjW8r3O3Y0B9ZtdLbqJwfprEmelF0oya0BYxRQuTQ655I XWhguXkiafAlxTuDwLJAUF3kDViXjBZKL2hBDsr1/spv64l23FYSKEtV5F9e0g7+jcRU HqJAo4XtWhLSsyNuWkeZpuBWCtIDG55RBTyUAYp14Q3C36S5KcTerPedbS92Qvmah53A Lxkw== X-Gm-Message-State: ACgBeo0bDJaoYM1viy7irIHLHIeQVLjs/5+FfKFV4Mmf0UWIEQNY95pQ u6cLzKpjfYZCttcStSunENO76KFjIJJXqbM/miHzGcQW X-Google-Smtp-Source: AA6agR5DUhsS+EDjj+L20Wx45CoqvOgOHudhletNCiXrnrvpp1mtMnhBrgGDIJ9+1tau/7MFpW0xhpfeHNVrpewq0lA= X-Received: by 2002:a81:b09:0:b0:345:30d:77b7 with SMTP id 9-20020a810b09000000b00345030d77b7mr2523925ywl.177.1662547697349; Wed, 07 Sep 2022 03:48:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul B Mahol Date: Wed, 7 Sep 2022 12:51:25 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avocdec/flac_parser: another fix X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Sep 7, 2022 at 12:31 PM Mattias Wadman wrote: > On Mon, Sep 5, 2022 at 8:16 PM Paul B Mahol wrote: > > > Patch attached. > > > > Thanks and can confirm that the patch produces the same samples as the flac > reference decoder for the original file in > https://trac.ffmpeg.org/ticket/9621 that I could not share. > > But I'm not sure I follow how the patch works. I read it as we skip > checking CRC if the current frame or sample number is the expected next > one? > It always force CRC check if they do not match, previously code would do that sometimes. > > + if ((fpc->last_fi.frame_or_sample_num + 1 == > header_fi->frame_or_sample_num) || > + (fpc->last_fi.frame_or_sample_num + fpc->last_fi.blocksize == > header_fi->frame_or_sample_num)) { > > Would it make sense to look at the blocking strategy bit to know which one > to check? > Could be. _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".