From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EE36A4093C for ; Thu, 3 Mar 2022 17:36:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7928C68B074; Thu, 3 Mar 2022 19:36:37 +0200 (EET) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 248DF68AE64 for ; Thu, 3 Mar 2022 19:36:31 +0200 (EET) Received: by mail-yb1-f172.google.com with SMTP id h126so11778179ybc.1 for ; Thu, 03 Mar 2022 09:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=fmHTt9gYQiR4VsHbByeJahoVyl4zKfLglvCKYQXcgS8=; b=CLXsTizXDqTOjC2ray5iGSAQhknxpTC8pn8T2osOBA+Gh9AlTOpBVyplOeHPBN0KZM L9DR3OdUIVPql9qMuXrgcE/PW2dUnD+Z7+Wdfobv9rp0bCqMtmgC4otU98i29c9dNgLX iyCmqs6TOvxz6Gntm9tk3zZibIQYC3zbTYfY1Ihj5jQX3qNd7NXFc4k6DHMQvJwlkg+w m6hkmYEwcakHXmrHPj6FuYMmN4M51Xry7Qwmbsf4nozz564IAwC6WKq4lFvBmmNPXazU 12gKnheV+GJFkpQ42zs/xqT+azwVJL4/ddQ15ceHLIrR0IQOS6SOEi38Um7ot+RswYxY 49vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=fmHTt9gYQiR4VsHbByeJahoVyl4zKfLglvCKYQXcgS8=; b=mO+8+ZYfgzxCY2sxTZkMcccbjiU4BknnxMxZX7ZGxgpJpKvN9a9fhyM+hsDyuvrTr+ JXzywYExkkCW5oDeejArIosqC3n+J0pFQZMmh25qQt6XO5C5GU88tHeIcoT4NrC7YT+E ufYHxX7Hi4m5YhjY3jhQppVAxP3jKLP9FXzAQN3YkCtE74XZJHL5ws3GKy2vf6LR1I/9 v2kK1hCs93F1EIV3ucuQpc9qb13IIkPmM0Iqf6R/WjhiO5U+rteXxfWWPOgRUb/rf5pU HqIKIZOaq6d2OGKKN7v77Ju6M8pimCbT7bvv++0vI+SYdlWXvK2Gy0+gLkM7awGlekFw qxlw== X-Gm-Message-State: AOAM531frx9t6EjmIrzamBVz4x8N7YXdq25o+0BJK3p51zMkEmBbome+ qNcsVY2k5s3ZcAW8+rpkyb+AnBT2+iJ8P8p1IcvoEK1giik= X-Google-Smtp-Source: ABdhPJwXs+uVF93YclfP0K4pWFxORseXFZIFi3Z/nqEFAjZnzAobditMQZaNEXU5GitCECaXxOKlfrNoQEWQhe3oiHc= X-Received: by 2002:a25:da56:0:b0:628:b1e5:d2fe with SMTP id n83-20020a25da56000000b00628b1e5d2femr7011035ybf.49.1646328989956; Thu, 03 Mar 2022 09:36:29 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a0d:d9cf:0:0:0:0:0 with HTTP; Thu, 3 Mar 2022 09:36:29 -0800 (PST) In-Reply-To: <20161103103050.31714-1-michael@niedermayer.cc> References: <20161103103050.31714-1-michael@niedermayer.cc> From: Paul B Mahol Date: Thu, 3 Mar 2022 18:36:29 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Check expacc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/3/16, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ac3dec.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > index a95c204..499971a 100644 > --- a/libavcodec/ac3dec.c > +++ b/libavcodec/ac3dec.c > @@ -426,6 +426,10 @@ static int decode_exponents(AC3DecodeContext *s, > group_size = exp_strategy + (exp_strategy == EXP_D45); > for (grp = 0, i = 0; grp < ngrps; grp++) { > expacc = get_bits(gbc, 7); > + if (expacc >= 125) { > + av_log(s->avctx, AV_LOG_ERROR, "expacc %d is out-of-range\n", > expacc); > + return AVERROR_INVALIDDATA; > + } > dexp[i++] = ungroup_3_in_7_bits_tab[expacc][0]; > dexp[i++] = ungroup_3_in_7_bits_tab[expacc][1]; > dexp[i++] = ungroup_3_in_7_bits_tab[expacc][2]; > -- Please revert this ASAP. It breaks decoding valid files. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".