From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Check expacc
Date: Thu, 3 Mar 2022 18:36:29 +0100
Message-ID: <CAPYw7P5PEkq-=gmjdaiEG8KhagPTJHj9WM+C0bobes8+ZcVPFg@mail.gmail.com> (raw)
In-Reply-To: <20161103103050.31714-1-michael@niedermayer.cc>
On 11/3/16, Michael Niedermayer <michael@niedermayer.cc> wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/ac3dec.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c
> index a95c204..499971a 100644
> --- a/libavcodec/ac3dec.c
> +++ b/libavcodec/ac3dec.c
> @@ -426,6 +426,10 @@ static int decode_exponents(AC3DecodeContext *s,
> group_size = exp_strategy + (exp_strategy == EXP_D45);
> for (grp = 0, i = 0; grp < ngrps; grp++) {
> expacc = get_bits(gbc, 7);
> + if (expacc >= 125) {
> + av_log(s->avctx, AV_LOG_ERROR, "expacc %d is out-of-range\n",
> expacc);
> + return AVERROR_INVALIDDATA;
> + }
> dexp[i++] = ungroup_3_in_7_bits_tab[expacc][0];
> dexp[i++] = ungroup_3_in_7_bits_tab[expacc][1];
> dexp[i++] = ungroup_3_in_7_bits_tab[expacc][2];
> --
Please revert this ASAP. It breaks decoding valid files.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2022-03-03 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161103103050.31714-1-michael@niedermayer.cc>
2022-03-03 17:36 ` Paul B Mahol [this message]
2022-03-04 18:16 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P5PEkq-=gmjdaiEG8KhagPTJHj9WM+C0bobes8+ZcVPFg@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git