From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D17CB40707 for ; Wed, 29 Jun 2022 08:00:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 92BE468B760; Wed, 29 Jun 2022 11:00:48 +0300 (EEST) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CDFE968B45D for ; Wed, 29 Jun 2022 11:00:42 +0300 (EEST) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2ef5380669cso140102687b3.9 for ; Wed, 29 Jun 2022 01:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tn2e9jL2h3R9o1rSD32dSV08DDPVql0jQD/NClBHtYs=; b=XG4op/kbW0Kp5dUvdCPhhy+OQa6rYPbEVdwY4U34G9jKjHbP0jJvmBYV1kOLG+qg9A zqoWcai+Lm+N0zLG/TFyBg9O6llZIPL/Qvqzm0FuUpO9AcPsm8satXcsteL+ATwJ9usC pF46Uhx5qobognAX7m7BzBNyegts/t1Hrqq8jId9I0dwKNv5jXkQb9EWSnLS1Bd+MI9X jeEpv4kaDm94TzQ/mFaP6mrL5DYItK1DQqnm7t+hz/aylFKp8/d8bZ1FsdOhme5TmsHd RTXbouzFK3/C2Kyp7aOl1emaFWANQXSc+Cqu5p3RLweRFIKxjPXjkpJkVe3SvTLvF7Hf enjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tn2e9jL2h3R9o1rSD32dSV08DDPVql0jQD/NClBHtYs=; b=B1+KIelAe3LOButaS2EWBR8bieUV/tH2S5l7/7QCQQI1foPi3Igb4iAyUuHNwoVA2N XV/SJGGoGOdg6pUsoDm2SSvMTuztjWRb/3Wt3EPi9zhc28K1aiV+D8lQr0OcAsGrZFt5 EgeFrL35OPah48OOoL3wuZx+53OVdu7O0WfnsKCM/5X9GaxcSm+wf71Z1tH5djDZIkpT RUx5fGS/wY9xcfgqlWwG5ea4JXr9nl74YrmpKPebBCmcYJ476C4MLXZTq2chJwRyMEmU L0AV4HcV3fZloP5fFSAJyyDEWy2rUI+6LIysi93K30vzw3V3oU0wRw4RXFUOc56KWjgo 7dWw== X-Gm-Message-State: AJIora/pWH09yIkrqvDcXBKFflpnA0SBTofiObuVovNDTYvoe3l7ld1A gmxweCIIBY8t8VmMlSC5zejARHUmQLANlnLe7nV45zsV+bY= X-Google-Smtp-Source: AGRyM1uvKxw0l9l72neDYp64bE63RTGSfX39FuYddwhQ0igggDr5fz3c8psat7wTC9oePTzXRUdF+31ILCQNcFCfFN8= X-Received: by 2002:a0d:e841:0:b0:317:9fea:a18b with SMTP id r62-20020a0de841000000b003179feaa18bmr2462617ywe.302.1656489641322; Wed, 29 Jun 2022 01:00:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul B Mahol Date: Wed, 29 Jun 2022 10:03:27 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/8] avformat/bintext: Remove set-but-unused variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jun 28, 2022 at 1:27 PM Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > Maybe this was meant to be used somehow? > probably some not implemented logic to set probe depending on amount of invisible chars. > > libavformat/bintext.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/libavformat/bintext.c b/libavformat/bintext.c > index 0465b86f4b..b6f14a03e5 100644 > --- a/libavformat/bintext.c > +++ b/libavformat/bintext.c > @@ -132,8 +132,6 @@ static int bin_probe(const AVProbeData *p) > { > const uint8_t *d = p->buf; > int magic = 0, sauce = 0; > - int invisible = 0; > - int i; > > if (p->buf_size > 256) > magic = !memcmp(d + p->buf_size - 256, next_magic, > sizeof(next_magic)); > @@ -157,12 +155,6 @@ static int bin_probe(const AVProbeData *p) > if (par.height <= 0) > return 0; > > - for (i = 0; i < p->buf_size - 256; i+=2) { > - if ((d[i+1] & 15) == (d[i+1] >> 4) && d[i] && d[i] != 0xFF && > d[i] != ' ') { > - invisible ++; > - } > - } > - > if (par.width * par.height * 2 / (8*16) == p->buf_size) > return AVPROBE_SCORE_MAX / 2; > return 0; > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".