Re: [FFmpeg-devel] [PATCH 1/8] avformat/bintext: Remove set-but-unused variable

[Paul B Mahol <onemda@gmail.com>]

On Tue, Jun 28, 2022 at 1:27 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> Maybe this was meant to be used somehow?
>

probably some not implemented logic to set probe depending on amount of
invisible chars.

>
>  libavformat/bintext.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/libavformat/bintext.c b/libavformat/bintext.c
> index 0465b86f4b..b6f14a03e5 100644
> --- a/libavformat/bintext.c
> +++ b/libavformat/bintext.c
> @@ -132,8 +132,6 @@ static int bin_probe(const AVProbeData *p)
>  {
>      const uint8_t *d = p->buf;
>      int magic = 0, sauce = 0;
> -    int invisible = 0;
> -    int i;
>
>      if (p->buf_size > 256)
>          magic = !memcmp(d + p->buf_size - 256, next_magic,
> sizeof(next_magic));
> @@ -157,12 +155,6 @@ static int bin_probe(const AVProbeData *p)
>          if (par.height <= 0)
>              return 0;
>
> -        for (i = 0; i < p->buf_size - 256;  i+=2) {
> -            if ((d[i+1] & 15) == (d[i+1] >> 4) && d[i] && d[i] != 0xFF &&
> d[i] != ' ') {
> -                invisible ++;
> -            }
> -        }
> -
>          if (par.width * par.height * 2 / (8*16) == p->buf_size)
>              return AVPROBE_SCORE_MAX / 2;
>          return 0;
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".