From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A18B645456 for ; Mon, 30 Jan 2023 12:19:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB1DA68BC6F; Mon, 30 Jan 2023 14:19:31 +0200 (EET) Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A27EC68AD5C for ; Mon, 30 Jan 2023 14:19:25 +0200 (EET) Received: by mail-vs1-f49.google.com with SMTP id j7so12196909vsl.11 for ; Mon, 30 Jan 2023 04:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=G8ZfXQUThUu2V281yFNNRXbFMNqEjnpI5VFlp0CrA+4=; b=ZpEU04Vvydo60Xf6ARA1tC73CXySQxDqwUCSb/a+hIz04z7CIb81C/0fnyStrMEpby 32bIrfHGBXkaoo65/204FWKYMFWgswihkHyT0RDLjtmdSaBPFo04FR/KGx+2+FUsZBP1 YIS2U0i8q6zm45hme+1+J5X80tMalD+Co71GgW5WxbLS3qPoxF9Q4VuNHqx+p38MqLNy u8CtGoa+RsTw0IWLGg3DMA7MGppTWe2rCf9V0FEwIHV3VHqtiDkxUuqwrkYyWKqZrR8y ZEMGrRGmqKivmOEUOyzFWxOIdQk1cY11t1TxnQOm39sW/4zzFVB/6C0PXg8Lw0F3aJBX N2rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G8ZfXQUThUu2V281yFNNRXbFMNqEjnpI5VFlp0CrA+4=; b=NH1128YChtg8M43iQ9CzaiZWWwG5lkPip2dZk/yUgiQIwjgJWH7Q9db7fPwYBNfiDz s2Ecc0KjQ33DPGDWUcaGbbajCuzSckUK29IigC6WxmIJ1q0aBmiI7PranYffghFGyCsm MxCtEdR/vFmXeLkEDNkpKHbzPC6ZYy7PQH73EwxFWbi1i7KHK6CqTHDt6h2/ZwtscSnM 5MqLoykmQ5JVz0+HBGP3yK0zLv4U56TVntyrFFklLRU5w6aLJv79gv9YZplFcgIMjQX/ MXkefJzrF1vu+68F7dNxfkMzpt21Yto96BRBRfGze9zgPBSBpqTkyoCWiFnxqwsNZJIA 8Vsw== X-Gm-Message-State: AO0yUKXNMn1jnNuZNRbAUqoUU41h7ujVjT3v2LT6qWuC5q0dD27GJM3f xciyIRVHjekZqhBg/b6rPbR/6HZ6nbNxXUc5/xBUCyiL X-Google-Smtp-Source: AK7set9mdiR/X7mTXT3/K6skUV26jrEXL0nXv5n56shX0LVmrSO0UJRxBgsqFZQ4fsjfs/mpQ9+Zmptfoe1X6ElsTpU= X-Received: by 2002:a05:6102:3550:b0:3f1:7158:eebd with SMTP id e16-20020a056102355000b003f17158eebdmr1112531vss.15.1675081164329; Mon, 30 Jan 2023 04:19:24 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Mon, 30 Jan 2023 04:19:23 -0800 (PST) In-Reply-To: <9ae25c06-73ce-f3b6-7a29-3dd8e3e530c3@tiscali.it> References: <8d713a21-f2f0-5c8d-fa93-0278965509e5@tiscali.it> <47ee718c-bce0-cffa-9c6a-2889a6547017@tiscali.it> <9ae25c06-73ce-f3b6-7a29-3dd8e3e530c3@tiscali.it> From: Paul B Mahol Date: Mon, 30 Jan 2023 13:19:23 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] drawtext filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/30/23, Francesco Carusi wrote: > On 28/01/2023 16:32, Paul B Mahol wrote: >> On 1/28/23, Francesco Carusi wrote: >>> On 27/01/2023 18:31, Paul B Mahol wrote: >>>> On 1/27/23, Francesco Carusi wrote: >>>>> On 26/01/2023 17:37, Paul B Mahol wrote: >>>>>> On 1/26/23, Francesco Carusi wrote: >>>>>>> On 26/01/2023 14:21, Paul B Mahol wrote: >>>>>>>> On 1/26/23, Francesco Carusi wrote: >>>>>>>>> The drawtext reinit command is also used in the docs as an example >>>>>>>>> for >>>>>>>>> the sendcmd filter, so I thought it was fine to use commands in >>>>>>>>> that >>>>>>>>> way. In my opinion it is also a convenient way to modify multiple >>>>>>>>> options at the same time. >>>>>>>>> Should the command match the name of a filter option instead? >>>>>>>>> >>>>>>>> Please do not top post. >>>>>>>> >>>>>>>> It is much better to use already existing options for commands that >>>>>>>> is >>>>>>>> more intuitive to users. Also multiple options can be set at >>>>>>>> runtime, >>>>>>>> there is no such limitation. >>>>>>> ok, I'm going to remove the "change" command and add commands that >>>>>>> match >>>>>>> the options that it included. >>>>>> Thanks, feel free to ask questions on #ffmpeg-devel irc channel. >>>>> I'm attaching the updated patch, I also updated the document at >>>>> https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md >>>>> Thanks >>>> Amazing, I like demos! >>>> >>>> Could improve code style of newly added/changed lines? >>>> For example opening { put on separate line. So code style is in sync >>>> with rest of codebase. >>> Sure, I'll put opening { on a new line for functions, not for control >>> statements, like in the rest of the code. Is it fine? >> Yes. Thanks. >> >>>> The commands stuff does not need to use strcmp to detect if option >>>> value have been changed, you could avoid strcmp by just caching old >>>> value prior to calling function the picks new values, and after that >>>> just compare old with new and then if it differs call needed code. >>> I'll cache the numeric values. I think that caching string values is not >>> the preferred solution because in addition to the strcmp needed to check >>> the value, it would also need a strdup to cache the previous value, even >>> when the command does not involve those options. Does it sound >>> reasonable? >> Yes. > I'm attaching the patch that includes the changes we discussed. space between 'for' and '(' Do not keep old code in comments if its no longer relevant or working. > >> >>>>>>>>> On 26/01/2023 11:50, Paul B Mahol wrote: >>>>>>>>>> On 1/26/23, Francesco Carusi wrote: >>>>>>>>>>> Hi, I'm new to contributing to ffmpeg! >>>>>>>>>>> >>>>>>>>>>> I modified the drawtext filter to improve text rendering and add >>>>>>>>>>> some >>>>>>>>>>> features. You can find a high level description of the changes >>>>>>>>>>> at >>>>>>>>>>> this >>>>>>>>>>> link: >>>>>>>>>>> >>>>>>>>>>> https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md >>>>>>>>>>> >>>>>>>>>>> I'm also attaching the patch file. >>>>>>>>>>> I looked for the filter maintainer to discuss about the changes >>>>>>>>>>> I >>>>>>>>>>> made >>>>>>>>>>> but it looks like there isn't any, am I correct? >>>>>>>>>>> >>>>>>>>>>> Please let me know if this is the right way to submit my >>>>>>>>>>> contribution. >>>>>>>>>> Why filter can not support normal commands for options? Like >>>>>>>>>> most/all >>>>>>>>>> other filters that have support for changing options values at >>>>>>>>>> runtime. >>>>>>>>>> >>>>>>>>>> The reinit and yours added change option(s) are very >>>>>>>>>> strange/inconvenient things to do. >>>>>>>>>> _______________________________________________ >>>>>>>>>> ffmpeg-devel mailing list >>>>>>>>>> ffmpeg-devel@ffmpeg.org >>>>>>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>>>>>> >>>>>>>>>> To unsubscribe, visit link above, or email >>>>>>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>>>>>> _______________________________________________ >>>>>>>>> ffmpeg-devel mailing list >>>>>>>>> ffmpeg-devel@ffmpeg.org >>>>>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>>>>> >>>>>>>>> To unsubscribe, visit link above, or email >>>>>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> ffmpeg-devel mailing list >>>>>>>> ffmpeg-devel@ffmpeg.org >>>>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>>>> >>>>>>>> To unsubscribe, visit link above, or email >>>>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>>>> _______________________________________________ >>>>>>> ffmpeg-devel mailing list >>>>>>> ffmpeg-devel@ffmpeg.org >>>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>>> >>>>>>> To unsubscribe, visit link above, or email >>>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>>>> >>>>>> _______________________________________________ >>>>>> ffmpeg-devel mailing list >>>>>> ffmpeg-devel@ffmpeg.org >>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>> >>>>>> To unsubscribe, visit link above, or email >>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>> _______________________________________________ >>>> ffmpeg-devel mailing list >>>> ffmpeg-devel@ffmpeg.org >>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>> >>>> To unsubscribe, visit link above, or email >>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".