From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CD5D143F11 for ; Sun, 18 Dec 2022 18:14:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A201068B930; Sun, 18 Dec 2022 20:14:35 +0200 (EET) Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BEA1B689CDF for ; Sun, 18 Dec 2022 20:14:29 +0200 (EET) Received: by mail-vs1-f50.google.com with SMTP id d185so6918274vsd.0 for ; Sun, 18 Dec 2022 10:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=RIc0tL5on+pvvnsWNfSSuQAnS/+9NUPy67hkRY4GQL0=; b=SCk2MwUDDd1eQNwaElVeKpRkprNXXlwg0NS5c4vc19oDtjuhKSDVDO7NrTsr6sh6H/ i1TGbYicCPCUPZN/BFHkbOg4a1PO19IHZzvpaJGFLV8dq2VJQpMMSO7rOxOfy5UyYVch C8LSC/4J6qP1DeGN5Ibylv4MUkMwKGhqLia83ok8y3vMgu4Bx8AqjdiKNHQkq+KNQU3d IWUUkpzWPVOC3n0o01iZ3yjfDsOWb944GXt/YJegIQnfUC7rE3vhYjnCC9VgrsFMRYo7 Etig3F6X4ulSI+9jLWXlRKUMces1RJh0IdrqnwlvPgTsWw0T+BkUt1qq09POVGlXX5E0 eNcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RIc0tL5on+pvvnsWNfSSuQAnS/+9NUPy67hkRY4GQL0=; b=7TVqACNnpR1Brbbr8eSrnhLgp0AjzpdtsO499/SQi0uC6snAB2a8viWT4PMW2h93I2 8Kc/xmAcS+qpviIQtdk2zFUEgecFQqh68+Yq9zDXx89aS3UD3FItdnXxLgE1G/GCgFNQ gfWxun7Yk1S9Bl1+83nbv5FbD1mFGaJV64la5SfUAuuCtjbi9uruTg6DUBlHpMSNHAxW qRm5g+vGy5NaCf7E8oFIpqFO3hFKmtu31pXtsYD/Vhs2gcDzTpO4ZxSdruGhSccipQtZ SXdxAe1t6C1rDk5C2bIW5HLmtGWapEcfJZ1foJmlfKz5Qb3b7Ey3LSVYNlS02CuO6kge j/uw== X-Gm-Message-State: ANoB5pmJpKmR6y4wy1WJZhJ/eWR6RIXWt6XGj2hfxwpWfaAmnqLf1yk3 oD3zNSqLrAeaM89fmfFJAViNc69YygY/9UTrr4mvULH7 X-Google-Smtp-Source: AA0mqf5y0rTRNZFSyZRcvz59HEJxa1KwuRNqwX5WZGijM+cMWdpJXv5xY2ybnbd9Nrfc3a75wJ1C5o+0eaEw6G0pt7o= X-Received: by 2002:a05:6102:3751:b0:3af:b950:489d with SMTP id u17-20020a056102375100b003afb950489dmr58750747vst.36.1671387268097; Sun, 18 Dec 2022 10:14:28 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Sun, 18 Dec 2022 10:14:27 -0800 (PST) In-Reply-To: <20221218170823.32130-5-michael@niedermayer.cc> References: <20221218170823.32130-1-michael@niedermayer.cc> <20221218170823.32130-5-michael@niedermayer.cc> From: Paul B Mahol Date: Sun, 18 Dec 2022 19:14:27 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/wavpack: Avoid undefined shift in get_tail() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/18/22, Michael Niedermayer wrote: > Fixes: left shift of 1208485947 by 1 places cannot be represented in type > 'int' > Fixes: > 54058/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5827521084260352 > Please use something else than casting. > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c > index 3cb4077550..42859ab0a1 100644 > --- a/libavcodec/wavpack.c > +++ b/libavcodec/wavpack.c > @@ -129,7 +129,7 @@ static av_always_inline unsigned get_tail(GetBitContext > *gb, unsigned k) > e = (1LL << (p + 1)) - k - 1; > res = get_bits_long(gb, p); > if (res >= e) > - res = (res << 1) - e + get_bits1(gb); > + res = ((unsigned)res << 1) - e + get_bits1(gb); > return res; > } > > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".