From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2026D42E9E for ; Thu, 12 May 2022 06:23:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 25EC068B45B; Thu, 12 May 2022 09:22:59 +0300 (EEST) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A970568B354 for ; Thu, 12 May 2022 09:22:52 +0300 (EEST) Received: by mail-yb1-f171.google.com with SMTP id x17so7985094ybj.3 for ; Wed, 11 May 2022 23:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=hbz+TZQM2f536/RSqo6Tfa++ylPLBwsr5VcZUA3m9DY=; b=bRJfZQgPj/avVgRlmPe7MEzFpqgoMS9Jey1SFT7IBwP2omplaJP2WzR7ltilFxahnW uzDYZatTvChTl5xJW6xOGoPWdxKGjAzo1FWftBJA1Lg0XpOO2O4s0tiINs1GXghZdjsB mHNSMFfOoKXBp2U6Lr3wpObsVNSqWrb3N8L7zn95nTPQkh2KV99jEhff6zPlSYAqJciv wgEYML1UDEJoVnnqxpAmvUXItD7q0nOGNGo9No4X8jeqmtyUR8XRXtL/v0aC9fxV8DQo v2nSG/tP3ksZOnAcWLLUZa1mANoIQG6ojZTZNEQh9bre8p903TlEc8NShf9NVcW3TfOg A5gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=hbz+TZQM2f536/RSqo6Tfa++ylPLBwsr5VcZUA3m9DY=; b=TUnaKrejowPtX+jPJrUW+YrCSlSnnAJ1nuLPWa4wVyeKJKmrqul/wHLWLczgA7ToJD yAUMClTdAyP+xGitZz7r8AIq4i8oy0La7QqqxHlYWwxTZskn23Llcr1VA65rE5RcEj2c 05wfNz2DZiDl79y4+qCZNEWFHPYX5N3SXxbI57W5/6z+XzU43w7zIARJcTsvrTDi0pUN /YXvkl5St+U226bF27lT4gpJuOseJDmCKqdtxNYFMOPEb8VA47+k0cFb4XeeC3PR80cQ NbtSr0quWblVFxD+WSEHufpdT6PVVYm6dj4D50TYwhbPopgVgJ0R1bIfbS1F9IDxcvWe oJrQ== X-Gm-Message-State: AOAM532Vi/8h1WUrMuwF5j7AknF/G7IBosLRMvKHIScLVwavSG7G98fZ qpYogtr50yx4vVbDAEW2wI1O7WdpNdWFBGzICLazV4Yq X-Google-Smtp-Source: ABdhPJwNw1QM1q1W8/hKc2lzkUHnnPjShMdxPelMcJ0+AOD9NnlBbVTv4y9R7f06JEgtlQOpybSFN54FWDbeZjHRPGw= X-Received: by 2002:a25:94a:0:b0:615:7cf4:e2cd with SMTP id u10-20020a25094a000000b006157cf4e2cdmr27256326ybm.227.1652336571201; Wed, 11 May 2022 23:22:51 -0700 (PDT) MIME-Version: 1.0 References: <1652280498-10408-1-git-send-email-lance.lmwang@gmail.com> <1652280498-10408-2-git-send-email-lance.lmwang@gmail.com> <20220511233840.GA15884@gmail.com> In-Reply-To: <20220511233840.GA15884@gmail.com> From: Paul B Mahol Date: Thu, 12 May 2022 08:25:29 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, May 12, 2022 at 1:39 AM wrote: > On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol wrote: > > why? > > assuming the len is 1, the following code will access the next 3 > array anymore, I think it's better to check the i with len -2. > > for (i = 0; i < len; i += 3) { > to > for (i = 0; i < len - 2; i += 3) { > > for the return, I think it's correct to return the used length, > if it's error, have return already. right? I doubt so. > > > -- > Thanks, > Limin Wang > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".