Re: [FFmpeg-devel] [PATCH 1/3] closed caption decoder: accept and decode a new codec type of 'raw 608 byte pairs'

From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] closed caption decoder: accept and decode a new codec type of 'raw 608 byte pairs'
Date: Tue, 20 Jun 2023 09:08:42 +0200
Message-ID: <CAPYw7P5DXvYjTKt_CMSYgUypVfBcrcCH2QVPE=4GrL1+f+DEGQ@mail.gmail.com> (raw)
In-Reply-To: <CAL1QdWeKVHUw=8bX3-Fzt701h1XqVQZEkgZOne=SwOCutCBoLw@mail.gmail.com>

On Tue, Jun 20, 2023 at 2:50 AM Roger Pack <rogerdpack2@gmail.com> wrote:

> OK updated patches to work with latest git master, made coded id less
> verbose.
> These have been tested against a "real device" and seem to work properly.
> I'd like to get feedback on the Closed caption decoder first if that's
> possible.
> I pinged the decoder "maintainer" about it once and didn't get a
> response so seems it's up to us.
>
>
Please remove '_dec_' part, its really not needed.

Thank you.
> -=roger=-
>
> On Thu, May 7, 2020 at 7:06 AM Paul B Mahol <onemda@gmail.com> wrote:
> >
> > Is it just me, or the coded id is too much verbose?
> >
> > On 5/7/20, Anton Khirnov <anton@khirnov.net> wrote:
> > > Quoting Roger Pack (2020-04-28 08:15:19)
> > >> From 5d7c12a3f703e794e1092087355bc9523d5f4d93 Mon Sep 17 00:00:00 2001
> > >> From: rogerdpack <rogerpack2005@gmail.com>
> > >> Date: Tue, 28 Apr 2020 05:15:15 +0000
> > >> Subject: [PATCH 1/3] closed caption decoder: accept and decode a new
> codec
> > >>  type of 'raw 608 byte pairs'
> > >>
> > >> Signed-off-by: rogerdpack <rogerpack2005@gmail.com>
> > >> ---
> > >> diff --git a/libavcodec/codec_id.h b/libavcodec/codec_id.h
> > >> index e7d6e059db..805e18758b 100644
> > >> --- a/libavcodec/codec_id.h
> > >> +++ b/libavcodec/codec_id.h
> > >> @@ -513,6 +513,7 @@ enum AVCodecID {
> > >>
> > >>      AV_CODEC_ID_MICRODVD   = 0x17800,
> > >>      AV_CODEC_ID_EIA_608,
> > >> +    AV_CODEC_ID_EIA_608_RAW_BYTE_PAIRS,
> > >
> > > You can't just add new IDs in the middle of the table, it changes the
> > > IDs of all the following codecs which breaks ABI.
> > > Add it to the end of the subtitle block.
> > >
> > > --
> > > Anton Khirnov
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >
> > > To unsubscribe, visit link above, or email
> > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".