From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 28C0B4377E for ; Fri, 25 Nov 2022 22:34:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A889568BC81; Sat, 26 Nov 2022 00:34:13 +0200 (EET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2E4E468BC1C for ; Sat, 26 Nov 2022 00:34:07 +0200 (EET) Received: by mail-vs1-f47.google.com with SMTP id t5so5389194vsh.8 for ; Fri, 25 Nov 2022 14:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kiZzaQayUKBfOz+7eRz1CWPOYb+w5V34mKT2RGvVIeg=; b=WhCsDYyNTHjjqfkR+6F8qG1Stjahg89IFphCl0xJIllvYuFriY7F1lybYHrMHSsy+k qeGC3Zwa4EjbmNLkeAvZamr+JJKQiDw9UT/aNpn9lgGDDbVyTCDbPKIzPR3apaYj+NPj SRC5UPQ50JB6fry8T6QJbqNB3bgm+9JzsN25TWzGK7I44aaPZpajjZSdeFIWW2bpar// XwRV6yAd1PVHhC2k6FjuTabPxOR6sNuRlhu7UUyl/qdWoMLoHa7K6keLAAJZb5ahZ4R5 XvhaXz2p2pYcPg5YUTWuRVLhQdM7Hz+UnexV/UJUpBwNUV4bUBskqKhxshkMD8el7SqT 1VBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kiZzaQayUKBfOz+7eRz1CWPOYb+w5V34mKT2RGvVIeg=; b=2N4AMt1ElllcXMgJOus9gosT77e8wl6uQrZRV2pjlI1C/5b1bWHqxYvr7UUwYoodKC AO6e5h1JCCnQLkcAMqpZKXsgGmUS55un3FEmPxbDRHWWD5xpeLd25dFlVUB5yg4AZYe9 +n1GGdyZxMfnd87VRv4OTt69quQTRL30b9pDIwwHQvT+n7ewLrZFbt4rwq6VgNZIJXXy mtL/k17FlXZqxdACtugDoIwOPG1OYMqGGHYpGy/XMvCVtE6Au1QrKGnDGK0/gG/Apy5p pLWq6PAzuUOa2if+wzREZdMF+SGEl10cOGtwoORQ1BeEWuqmkTvMHsOBRWuE0eLW1HEZ FRow== X-Gm-Message-State: ANoB5pkv1pKXdXKWAEI+ecIfTY7qigb836qgGeb4gMmJKKDuhl9u6G3b nOcZ8n0uHR10SEB0KmqYxPnpaZx8W8IYrHdydma0N49c X-Google-Smtp-Source: AA0mqf6BaH3I+ndNRhTKRg8O5AfiLH6IxljNSFlIgscjtPaS3GBzM68W9ND3h2t5L83HEQatyLoQZApo9pbH/jMv0Ig= X-Received: by 2002:a67:c906:0:b0:3aa:f64:fbfd with SMTP id w6-20020a67c906000000b003aa0f64fbfdmr14440039vsk.15.1669415645604; Fri, 25 Nov 2022 14:34:05 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Fri, 25 Nov 2022 14:34:04 -0800 (PST) In-Reply-To: <20221011172437.36211-1-mvanb1@gmail.com> References: <20221011172437.36211-1-mvanb1@gmail.com> From: Paul B Mahol Date: Fri, 25 Nov 2022 23:34:04 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Martijn van Beurden Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/11/22, Martijn van Beurden wrote: > Recently libFLAC gained the ability (first released in FLAC 1.4.0) > to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit integers, which the encoder must make sure of. In case > the encoder cannot find any predictor of which the residuals fit > this limit, it must default to using a verbatim subframe. Tests have > shown that this does not happen often (<0.1% of subframes on a > music corpus of various styles). See also discussion here: > https://github.com/ietf-wg-cellar/flac-specification/pull/148 > > These two patches implement decoding and encoding following this > format. > > Changes since v1: > fix copy-paste error in encoder, several invocations of > lpc_encode_choose_datapath used wrong parameters, making FATE fail as > compression was less than it should be > > Changes since v2: > Rebased decoder part as it didn't apply anymore > > Changes since v3: > Moved put_golomb part to flacenc.c (as it is now quite specific to FLAC) > and renamed put_sbits64 to put_sbits63 (and changed assert accordingly) > > Changes since v4: > Fix check of decoded_buffer_33bps malloc. Fix reading of wasted bits > for 33bps subframe. Add fate test > > Changes since v5: > Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced > -strict -2 with -strict experimental in fate and encoder warning. > > Changes since v6: > Deduplicated function bodies with preprocessor macros in both > encoder and decoder, declared variables in loop body where possible > and changed ff_ctz to ff_ctzll where necessary > > Martijn van Beurden (3): > libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM > libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM > fate/flac: Add test of 32 bps encoding/decoding > > libavcodec/flac.c | 4 +- > libavcodec/flacdec.c | 218 ++++++++++++++++-- > libavcodec/flacenc.c | 480 +++++++++++++++++++++++++++++++--------- > libavcodec/get_bits.h | 12 + > libavcodec/mathops.h | 9 + > libavcodec/put_bits.h | 7 + > libavcodec/put_golomb.h | 14 -- > tests/fate/flac.mak | 4 + > 8 files changed, 602 insertions(+), 146 deletions(-) > > -- > 2.30.2 > If this is OK, will apply soon. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".