From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B775A40B46 for ; Mon, 7 Mar 2022 19:06:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6BB9668B104; Mon, 7 Mar 2022 21:06:46 +0200 (EET) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF6E968AEE4 for ; Mon, 7 Mar 2022 21:06:39 +0200 (EET) Received: by mail-yb1-f176.google.com with SMTP id g1so32997452ybe.4 for ; Mon, 07 Mar 2022 11:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=BvEnvuy8lQ1dVZMuqlR7TdPMZHtZHi9imNQppEOr1N4=; b=FnRev0lIPtRkxgdGDo+CJzoF57KnyPb3VBW3/mTZqLbYX34QVkCUJHS18iInkWnw2v KzFmykTbKaZoH/OKBEWU8/uvCWPgL3kNbaG68Q7QxCW9tja+OVMeW0bhTE/KCc/Po2MS wXaKj6K1FJXRuocqKKTqh19r8/fMoSOLdRY40wAL4fHvnEOrjk83tK3QvQYNX+by7K9g 95s+/RU9KoIcn5Nae/7OBeRx3CQv9LYqid82URCI3dfS+JVnZGAdCJ/sMtERzlCSL+40 QoF232+rEH5w0TARNakgEKEujT6pRvDSUvHnJOPDNM3/NK6TOIg5ZCU0joWbxBdBgszi Fjvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=BvEnvuy8lQ1dVZMuqlR7TdPMZHtZHi9imNQppEOr1N4=; b=bt/+72KX3TzPh5a0gLhT7FvJ6a7TzF49aYt5uFcZDAlyGqgBsZfDKcUIF915KEjZJO tzl+pmOjx6d4N5w3qsY0Cdi0GBQhcNzKG+mdh/kezp0D5EYPdBPSsSjSlzxOBbi+3e9I CdU62rMzY3Q5ntl4Z/OjIZtkmxUqYI2MzoLIxtVnkGpZUwYJbCLHbP8cCf4x/e4c+Vah 1aiYWdRQZJOkeoa2u2S1nd8JyNPNMJSwH39UN1LyasmHlz22XW9XpWwd2w86fqfBCrv1 axtjaSmzw05WWCjuxt1rMVK8rFUjKZhSmNKJzIYKI2vOGP4kWqGGHisFB5xchg7khnws npJQ== X-Gm-Message-State: AOAM531mOVfc58mFcKaziRc3ykhIwlMOTGu4Kink6kIO1c5IOSyx9vLm bZPsFU+6iQY6xN/kH++PGifvXe681/N6csWBu+azEC10 X-Google-Smtp-Source: ABdhPJx3/AsHAHTvrXAoFCfAlk/eoNegmiaoqZt9eMyhDPo2preUMiNTM9Renn+6Ii3tcbV3/+wr5n5AcB+KAb8+KmI= X-Received: by 2002:a25:2c86:0:b0:629:1915:3bbe with SMTP id s128-20020a252c86000000b0062919153bbemr8324672ybs.49.1646679998315; Mon, 07 Mar 2022 11:06:38 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:690c:12:0:0:0:0 with HTTP; Mon, 7 Mar 2022 11:06:37 -0800 (PST) In-Reply-To: <2621fec9-555f-c977-b378-dbfd7a6d115e@mail.de> References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> <164363001951.23111.4989616914372511566@lain.red.khirnov.net> <14fa7592-4acc-2186-335b-56ea500f9663@mail.de> <2621fec9-555f-c977-b378-dbfd7a6d115e@mail.de> From: Paul B Mahol Date: Mon, 7 Mar 2022 20:06:37 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/7/22, Thilo Borgmann wrote: > Am 06.03.22 um 22:25 schrieb Paul B Mahol: >> On 3/6/22, Thilo Borgmann wrote: >>> Am 22.02.22 um 12:30 schrieb Thilo Borgmann: >>>> Am 18.02.22 um 17:08 schrieb Paul B Mahol: >>>>> On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann >>>>> >>>>> wrote: >>>>> >>>>>> Am 31.01.22 um 12:55 schrieb James Almer: >>>>>>> >>>>>>> >>>>>>> On 1/31/2022 8:53 AM, Anton Khirnov wrote: >>>>>>>> Quoting Thilo Borgmann (2022-01-18 14:58:07) >>>>>>>>>>> Violations of code style. >>>>>>>>> >>>>>>>>> Enhanced. >>>>>>>> >>>>>>>> Not enough. There are still many remaining, e.g. >>>>>>>> * opening brace of a function definition should be on its own line >>>>>>>> * the context should generally be the first argument >>>>>>>> * unsigned char* should be uint8_t* >>>>>>>> * mixed declarations and code (the compiler should warn about that) >>>>>>> >>>>>>> I think someone said that clang (or some versions) is apparently not >>>>>> warning about this, hence why so many of these end up being missed in >>>>>> reviews or even by the patch author. >>>>>> >>>>>> This and all of Anton's comments in v3. Also removed some more >>>>>> obviously >>>>>> useless doubles. >>>>>> >>>>> >>>>> Why it uses doubles in so many places? >>>>> Is there any real benefit in that, except extra slowdown? >>>> >>>> I guess because it's originating in some c&p Matlab code. >>>> I did %s#double#float#g for v4, loosing some precision we can ignore >>>> IMHO. >>>> >>>> >>>> >>>> v3: >>>> >>>> Total frames: 2 >>>> >>>> Spatial Information: >>>> Average: 165.451985 >>>> Max: 165.817542 >>>> Min: 165.086427 >>>> >>>> Temporal Information: >>>> Average: 1.007263 >>>> Max: 2.014525 >>>> Min: 0.000000 >>>> >>>> >>>> >>>> v4: >>>> >>>> Total frames: 2 >>>> >>>> Spatial Information: >>>> Average: 164.385895 >>>> Max: 164.742325 >>>> Min: 164.029480 >>>> >>>> Temporal Information: >>>> Average: 1.007241 >>>> Max: 2.014483 >>>> Min: 0.000000 >>>> >>> >>> Ping. >> >> Into wrong section of changelog added entry. >> >> Useless cast of allocation results. >> >> Does filter changes pixels? If not, add metadata flag to appropriate >> place. > > All addressed in v5, thx! > Changelog entry is still in wrong, 5.0, section. > Also added a FATE test for it. > > -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".