From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support
Date: Wed, 2 Mar 2022 20:11:18 +0100
Message-ID: <CAPYw7P56LHGvHrsbBTVBLFuwe04pLgdNyc43R9RAjGBpCK19Xg@mail.gmail.com> (raw)
In-Reply-To: <20220302130045.GZ2829255@pb2>
On 3/2/22, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote:
>> It seems it does not work properly.
>>
>> Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> ---
>> libavcodec/mpegvideo_enc.c | 23 +++--------------------
>> 1 file changed, 3 insertions(+), 20 deletions(-)
>
> if iam not mistaken, that requires the whole image to be copied
> one extra time
> i think before doing that it should be understood
> where the problem is
> and why that is the better solution to fixing it and not doing
> that extra copy
>
> of course i may be missing something
>
Yea, If you manage to trigger that path, I'm all ears.
> thx
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Opposition brings concord. Out of discord comes the fairest harmony.
> -- Heraclitus
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-02 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 11:38 Paul B Mahol
2022-03-02 13:00 ` Michael Niedermayer
2022-03-02 19:11 ` Paul B Mahol [this message]
2022-03-02 21:47 ` Michael Niedermayer
2022-03-03 1:34 ` Andreas Rheinhardt
2022-03-03 8:24 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPYw7P56LHGvHrsbBTVBLFuwe04pLgdNyc43R9RAjGBpCK19Xg@mail.gmail.com \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git