From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9AE964456E for ; Sun, 18 Dec 2022 23:03:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1FFA668BA02; Mon, 19 Dec 2022 01:03:14 +0200 (EET) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5038968B353 for ; Mon, 19 Dec 2022 01:03:07 +0200 (EET) Received: by mail-vs1-f41.google.com with SMTP id a66so7207578vsa.6 for ; Sun, 18 Dec 2022 15:03:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3nD4VhwHWshswUSTB2yRSEpirjbvyiL79HqWz5QnrSg=; b=Y0DPjUtO6/nLvw1Qpzen49dtcwwx1j0xPL/gnd/S8js4zTnTsf1G4xU7B1cnmBsHWs d+u1Vy+CL8F/Q9GLlDveqOdQ3XoxRP8Jy8ghyvo+5XDRH3quiT6dDS/zWo1jedx5EMqe AU6Dr3cLePSMZR+nMGQIioHjEhlwvehr7i3g1TatUjRQWCU+y+LN8zCJhN4fkfUgernz QpnEy2R6ltOvADuglahbIYy955cRdh2LuXSw1xwbqj7Oq23x60VscXgUVYfilmzsnumr xvj9/1W1sXs6Pmbg8RFtggL1sHwE5zs4NARMShysoYrNfnOC+f9TKy+V1nEeTBKuKDqq wL1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3nD4VhwHWshswUSTB2yRSEpirjbvyiL79HqWz5QnrSg=; b=tXjTrCyEBhhbJVAbAwapUBgToQYrvyCt6Q87nDmabA5ncNn/psGDHNb6LKUcjuIECO F5Ja+NthFh9t9bKpSfncaymlsrhyWxJ3Ip/DY9XDU2aa/eSsiiLIZnBWc+di6VwDT/YV 8lapfkNP7PvOyn1LSNOF1crrGReY8r1yXJlgm8IGdG0WXmIJPaSLGrzQha3fug0ViEap J8BSr/nW5LXd/+3nkG5SAtvADJVWr56VvT6JCi4047pN/GilHuVm+PWV162GswZH7C9K PFS6jWMSbqB8j3vlXwJYp+N/dmzV213Q9A7zWRWFApn+jxnNdqwgEAXisKFMrN270nHV JulQ== X-Gm-Message-State: ANoB5pl7cTQvngJLTm8YiK/OtAh+quf5D0RLLpWUB/wDcRb1ikDvoLSM 2kzsmIiZQ5aywyEXipuM0TZ/k1OceoJDVY7r5tY= X-Google-Smtp-Source: AA0mqf6BHm8+oRdGFvofU6BdB+ao+xeXjvnqdHHPPHc3Qy1BC2pzNL1w2QdFfEYHiW6p0A5z9fCVo6QoMp+g1OYxQO8= X-Received: by 2002:a05:6102:3751:b0:3af:b950:489d with SMTP id u17-20020a056102375100b003afb950489dmr58805703vst.36.1671404585846; Sun, 18 Dec 2022 15:03:05 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Sun, 18 Dec 2022 15:03:04 -0800 (PST) In-Reply-To: References: <20221011172437.36211-1-mvanb1@gmail.com> From: Paul B Mahol Date: Mon, 19 Dec 2022 00:03:04 +0100 Message-ID: To: Martijn van Beurden Subject: Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/11/22, Martijn van Beurden wrote: > Op do 1 dec. 2022 om 13:31 schreef Paul B Mahol : >> >> On 11/25/22, Paul B Mahol wrote: >> > On 10/11/22, Martijn van Beurden wrote: >> >> Recently libFLAC gained the ability (first released in FLAC 1.4.0) >> >> to create FLAC files containing 32-bit int PCM samples. To >> >> keep complexity reasonable, the choice was made to limit residuals >> >> to 32-bit integers, which the encoder must make sure of. In case >> >> the encoder cannot find any predictor of which the residuals fit >> >> this limit, it must default to using a verbatim subframe. Tests have >> >> shown that this does not happen often (<0.1% of subframes on a >> >> music corpus of various styles). See also discussion here: >> >> https://github.com/ietf-wg-cellar/flac-specification/pull/148 >> >> >> >> These two patches implement decoding and encoding following this >> >> format. >> >> >> >> Changes since v1: >> >> fix copy-paste error in encoder, several invocations of >> >> lpc_encode_choose_datapath used wrong parameters, making FATE fail as >> >> compression was less than it should be >> >> >> >> Changes since v2: >> >> Rebased decoder part as it didn't apply anymore >> >> >> >> Changes since v3: >> >> Moved put_golomb part to flacenc.c (as it is now quite specific to >> >> FLAC) >> >> and renamed put_sbits64 to put_sbits63 (and changed assert >> >> accordingly) >> >> >> >> Changes since v4: >> >> Fix check of decoded_buffer_33bps malloc. Fix reading of wasted bits >> >> for 33bps subframe. Add fate test >> >> >> >> Changes since v5: >> >> Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced >> >> -strict -2 with -strict experimental in fate and encoder warning. >> >> >> >> Changes since v6: >> >> Deduplicated function bodies with preprocessor macros in both >> >> encoder and decoder, declared variables in loop body where possible >> >> and changed ff_ctz to ff_ctzll where necessary >> >> >> >> Martijn van Beurden (3): >> >> libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM >> >> libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM >> >> fate/flac: Add test of 32 bps encoding/decoding >> >> >> >> libavcodec/flac.c | 4 +- >> >> libavcodec/flacdec.c | 218 ++++++++++++++++-- >> >> libavcodec/flacenc.c | 480 >> >> +++++++++++++++++++++++++++++++--------- >> >> libavcodec/get_bits.h | 12 + >> >> libavcodec/mathops.h | 9 + >> >> libavcodec/put_bits.h | 7 + >> >> libavcodec/put_golomb.h | 14 -- >> >> tests/fate/flac.mak | 4 + >> >> 8 files changed, 602 insertions(+), 146 deletions(-) >> >> >> >> -- >> >> 2.30.2 >> >> >> > >> > >> > >> > If this is OK, will apply soon. >> >> >> Last time to say no to this patchset. > > I haven't had any comments the last few weeks, it still applies > against current git and passed FATE. If you could apply it I would be > much obliged. > > Kind regards, > > Martijn van Beurden > Hi, if this still pastes FATE and compiles and applies I gonna apply it in next 48h. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".